Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps in "Build a sample app" do not work #1890

Closed
2 tasks done
xJonathanLEI opened this issue May 31, 2021 · 4 comments
Closed
2 tasks done

Steps in "Build a sample app" do not work #1890

xJonathanLEI opened this issue May 31, 2021 · 4 comments

Comments

@xJonathanLEI
Copy link

This is about:

  • Innaccurate/misleading documentation (e.g. technically incorrect advice)

Problem

The Build a sample app page does not mention that the wasm32-unknown-unknown target must be added for the steps to work. In fact, such instruction in only given in a much later page in Project Setup.

New comers expect everything just works™ on a quickstart page. So I'd suggest adding this command to that page:

rustup target add wasm32-unknown-unknown

Questionaire

  • I'd like to write this documentation
@AaronDovTurkel
Copy link

Still getting an error after following the steps...

image

@AaronDovTurkel
Copy link

Found issue with wasm bind-gen here
Had to do the following:
rustup target add wasm32-unknown-unknown --toolchain nightly
rustup run nightly trunk serve

@mc1098
Copy link
Contributor

mc1098 commented Jun 11, 2021

Hi @xJonathanLEI,
I've been looking through the docs too and it seems like someone has beaten you to the punch as the requirement for target 'wasm32-unknown-unknown' was added by this PR #1907 🎉.

@hamza1311
Copy link
Member

Now that PR #1907 is merged, I think this issue can be closed

@siku2 siku2 closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants