Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding caniuse data in event documentation #1948

Closed
Xavientois opened this issue Jul 9, 2021 · 3 comments
Closed

Embedding caniuse data in event documentation #1948

Xavientois opened this issue Jul 9, 2021 · 3 comments

Comments

@Xavientois
Copy link
Contributor

Xavientois commented Jul 9, 2021

If we want to take this one step further we could look at somehow embedding the appropriate data from the caniuse repo? That is well beyond the scope of this PR, so I will make another issue for this.

Originally posted by @Xavientois in #1945 (comment)

This might be handy for folks using events, but wanting to be aware of where they might not be supported.
Not sure how useful others think this would be, but I'd be down to give it a try.

@hamza1311
Copy link
Member

I don't think it's a good idea. It puts the maintainability burden on us. Anyone who wants to use a feature and is worried about it's support could just go to caniuse themselves

@Xavientois
Copy link
Contributor Author

That's fair. I guess the core problem I would want to see about addressing is less an issue in Yew and more an issue with the web on the whole.

What I would maybe picture instead could be a warning that the user could toggle on or off in their project that would throw a warning on compilation when they are making use of a non-standard feature.

One of the reasons I like the idea of using Rust in frontend web dev is that it gives us the assurance of compile-time checks, thus instilling confidence that the code works before it breaks at runtime. That's sort of the goal behind this proposal. I'm open to other ways of achieving that; I'm not tied to this approach.

@teymour-aldridge
Copy link
Contributor

teymour-aldridge commented Jul 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants