Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test to ensure the wasm binaries size don't get too large #2460

Closed
cecton opened this issue Feb 17, 2022 · 0 comments · Fixed by #2513
Closed

Adding test to ensure the wasm binaries size don't get too large #2460

cecton opened this issue Feb 17, 2022 · 0 comments · Fixed by #2513
Labels
A-ci Area: The continuous integration bug

Comments

@cecton
Copy link
Member

cecton commented Feb 17, 2022

As a web framework Yew needs to ensure future additions to the framework will have a good or a minimal impact on the size of the output wasm binaries. This is because we don't know where or how an app using Yew will be used. It could be used for a web site. Any extra bytes count if we don't want to boat the internet even more than it currently is.

The solution here would be to add a test to save and compare the size of the examples app we provide. Any difference in size should make the test fail so the developer will need to update the saved size to match the size of the wasm binaries generated in their branch. This will make the review process easier as it can make it clear to the reviewer that a change got impact on the size of the binary.

Related to #2396

@cecton cecton added the bug label Feb 17, 2022
@cecton cecton changed the title Adding test to ensure the wasm binaries size don't get to large Adding test to ensure the wasm binaries size don't get too large Feb 17, 2022
@hamza1311 hamza1311 added the A-ci Area: The continuous integration label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants