Size Comparison on Pull Requests #2513
Conversation
|
Hmm, seems like the build size comment is not going to take effect until this pull request is merged. |
|
When a workflow is triggered on a pull request, it has no access to post comments on the base repository. You can use This means that the code needs to be compiled within the fork and the comment needs to be posted from base repository so we need 2 workflows. See: https://github.com/yewstack/yew/runs/5520333803?check_suite_focus=true |
|
Why didn't it approve auto approve for you? |
| from typing import Dict, List, Optional | ||
|
|
||
| import os | ||
| import json | ||
|
|
||
| with open("size-cmp-info/.SIZE_CMP_INFO") as f: | ||
| content = json.loads(f.read()) | ||
|
|
||
| joined_sizes = content["sizes"] | ||
|
|
||
| lines: List[str] = [] | ||
|
|
||
| lines.append("### Size Comparison") | ||
| lines.append("") | ||
| lines.append("| examples | master (KB) | pull request (KB) | diff |") | ||
| lines.append("| --- | --- | --- | --- | ") | ||
|
|
||
| for (i, sizes) in joined_sizes: | ||
| (master_size, pr_size) = sizes | ||
| diff: Optional[int] = None | ||
|
|
||
| if master_size is not None and pr_size is not None: | ||
| diff = pr_size - master_size | ||
|
|
||
| master_size_str = "N/A" if master_size is None else ( | ||
| f"{master_size / 1024:.3f}" if master_size != 0 else "0" | ||
| ) | ||
| pr_size_str = "N/A" if pr_size is None else ( | ||
| f"{pr_size / 1024:.3f}" if pr_size != 0 else "0" | ||
| ) | ||
| diff_str = "N/A" if diff is None else ( | ||
| f"{diff / 1024:.3f}" if diff < 0 else ( | ||
| f"+{diff / 1024:.3f}" if diff > 0 else "0" | ||
| ) | ||
| ) | ||
| lines.append(f"| {i} | {master_size_str} | {pr_size_str} | {diff_str} |") | ||
|
|
||
| output = "\n".join(lines) | ||
|
|
||
| with open(os.environ["GITHUB_ENV"], "a+") as f: | ||
| f.write(f"YEW_EXAMPLE_SIZES={json.dumps(output)}\n") | ||
| f.write(f"PR_NUMBER={content["issue_number"]}\n") | ||
|
|
There was a problem hiding this comment.
I'd rather have these parts in proper files than inline in yaml files, but it's fine for now.
There was a problem hiding this comment.
This could go in the ci directory
There was a problem hiding this comment.
@futursolo, do you want to make this change? If not, please go ahead and merge this
|
Oh wow that is cool!!! |
Description
Fixes #2460
This pull request adds a comment on pull requests that compares the size of examples of master and pull requests.
Checklist
cargo make pr-flowPreview
For every pull request, a comment like the following will be made on the pull request automatically.
Size Comparison