Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 馃毃 Breaking changes section to changelog generator #3212

Closed
voidpumpkin opened this issue Apr 3, 2023 · 2 comments 路 Fixed by #3255
Closed

Add 馃毃 Breaking changes section to changelog generator #3212

voidpumpkin opened this issue Apr 3, 2023 · 2 comments 路 Fixed by #3255
Labels
good first issue meta Repository chores and tasks

Comments

@voidpumpkin
Copy link
Member

We generate our changelogs using our mini-tool https://github.com/yewstack/yew/tree/master/tools/changelog

It should now start caring for breaking changes label on github and categorizing entries into new category 馃毃 Breaking changes
@voidpumpkin voidpumpkin added good first issue meta Repository chores and tasks labels Apr 3, 2023
@voidpumpkin voidpumpkin mentioned this issue Apr 3, 2023
Closed
@voidpumpkin voidpumpkin changed the title Add 馃毃 Breaking changes section to cahngelog generator Add 馃毃 Breaking changes section to changelog generator Apr 3, 2023
@voidpumpkin voidpumpkin mentioned this issue Apr 3, 2023
Closed
@jellllly420
Copy link
Contributor

Hello, I'm new to Yew and I'd like to work on this issue.

I did some modification on the changelog generator to add breaking changes section and 4de50cc is the code. There is a new field is_breaking_change added to the LogLine struct and I'm not sure if it's an acceptable solution.

Thanks for any feedback.

@futursolo
Copy link
Member

I did some modification on the changelog generator to add breaking changes section and 4de50cc is the code. There is a new field is_breaking_change added to the LogLine struct and I'm not sure if it's an acceptable solution.

I think your implementation looks good.
Feel free to submit a pull request when you think it's ready.

@jellllly420 jellllly420 mentioned this issue May 1, 2023
Merged
2 tasks
hamza1311 added a commit that referenced this issue Aug 18, 2023
@jellllly420 @hamza1311
Add breaking changes section to changelog generator (#3255)
a27076d 
Fixes #3212

-------

* Add breaking changes section to changelog generator.

* re-design test of changelog

* format fix

* Update tools/changelog/tests/generate_yew_changelog_file.rs

Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>

---------

Co-authored-by: jelly <jelly.zhao.42@gmail.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue meta Repository chores and tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add breaking changes section to changelog generator jellllly420/yew
3 participants
@futursolo @voidpumpkin @jellllly420