Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks have inconsistent call signature #3371

Closed
1 of 3 tasks
futursolo opened this issue Aug 5, 2023 · 0 comments · Fixed by #3376
Closed
1 of 3 tasks

Hooks have inconsistent call signature #3371

futursolo opened this issue Aug 5, 2023 · 0 comments · Fixed by #3376
Labels

Comments

@futursolo
Copy link
Member

futursolo commented Aug 5, 2023

Problem

Steps To Reproduce
Steps to reproduce the behavior:

In #2861, most hooks has been updated to have dependency before init function.
However, some hooks still have an old signature (use_future_with_deps).

We should check all hooks to make sure they have consistent signature.

Expected behavior
A clear and concise description of what you expected to happen.

All hooks should have consistent call signature.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  • Yew version: master
  • Rust version: N/A
  • Target, if relevant: N/A
  • Build tool, if relevant: N/A
  • OS, if relevant: N/A
  • Browser and version, if relevant: N/A

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant