Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signature of use_future_with consistent #3372

Merged
merged 1 commit into from Aug 15, 2023

Conversation

hamza1311
Copy link
Member

@hamza1311 hamza1311 commented Aug 9, 2023

Description

Rename use_future_with_deps to use_future_with and change it's signature to bring it in line with other hooks that dependencies

See #3371

Checklist

  • I have reviewed my own code
  • [-] I have added tests

@hamza1311 hamza1311 added breaking change A-yew Area: The main yew crate labels Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Visit the preview URL for this PR (updated for commit e51cebb):

https://yew-rs-api--pr3372-use-future-with-izg1rjo2.web.app

(expires Wed, 16 Aug 2023 19:32:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.316 102.316 0 0.000%
boids 175.504 175.504 0 0.000%
communication_child_to_parent 95.223 95.223 0 0.000%
communication_grandchild_with_grandparent 108.894 108.894 0 0.000%
communication_grandparent_to_grandchild 105.552 105.552 0 0.000%
communication_parent_to_child 92.693 92.693 0 0.000%
contexts 110.877 110.877 0 0.000%
counter 89.204 89.204 0 0.000%
counter_functional 89.924 89.924 0 0.000%
dyn_create_destroy_apps 92.237 92.237 0 0.000%
file_upload 103.544 103.544 0 0.000%
function_memory_game 174.326 174.326 0 0.000%
function_router 348.018 348.018 0 0.000%
function_todomvc 163.348 163.348 0 0.000%
futures 227.709 227.709 0 0.000%
game_of_life 112.297 112.297 0 0.000%
immutable 188.940 188.940 0 0.000%
inner_html 86.013 86.013 0 0.000%
js_callback 112.995 112.995 0 0.000%
keyed_list 201.203 201.203 0 0.000%
mount_point 89.207 89.207 0 0.000%
nested_list 114.492 114.492 0 0.000%
node_refs 96.162 96.162 0 0.000%
password_strength 1582.834 1582.834 0 0.000%
portals 98.236 98.236 0 0.000%
router 314.135 314.135 0 0.000%
simple_ssr 143.648 143.648 0 0.000%
ssr_router 385.253 385.253 0 0.000%
suspense 110.174 110.174 0 0.000%
timer 91.757 91.757 0 0.000%
timer_functional 100.292 100.292 0 0.000%
todomvc 143.697 143.697 0 0.000%
two_apps 89.916 89.916 0 0.000%
web_worker_fib 154.511 154.511 0 0.000%
webgl 88.478 88.478 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 354.536 396.921 370.539 13.623
Hello World 10 644.987 703.612 669.669 22.124
Function Router 10 2292.806 2483.929 2356.542 51.809
Concurrent Task 10 1007.990 1011.323 1009.494 0.902
Many Providers 10 1493.931 1647.380 1567.623 46.139

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 351.447 385.293 365.007 10.859
Hello World 10 658.824 735.862 682.816 24.010
Function Router 10 2259.880 2488.278 2346.555 72.698
Concurrent Task 10 1006.906 1010.708 1009.100 1.074
Many Providers 10 1534.949 1666.124 1575.393 48.856

github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think use_prepared_state and use_transitive_state also has deps as the second argument.

Could you please update those hooks as well?

@hamza1311
Copy link
Member Author

I think use_prepared_state and use_transitive_state also has deps as the second argument.

Could you please update those hooks as well?

@futursolo, that is done in #3376

@futursolo
Copy link
Member

I have updated the pr comment so it will not close the original issue.

@futursolo futursolo merged commit 41d42fb into yewstack:master Aug 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants