Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings #34

Closed
wldcordeiro opened this issue Dec 28, 2017 · 3 comments
Closed

Compiler warnings #34

wldcordeiro opened this issue Dec 28, 2017 · 3 comments

Comments

@wldcordeiro
Copy link
Contributor

Looks like there are some warnings related to mutability where it isn't needed?
@wldcordeiro wldcordeiro mentioned this issue Dec 28, 2017
Merged
@therustmonk
Copy link
Member

@wldcordeiro I've merged changes from #35. Thank you! But could you tell me how did you get that warnings? I use rustc 1.24.0-nightly (4a7c072fa 2017-12-25) and it doesn't show any warnings to me.

@wldcordeiro
Copy link
Contributor Author

@deniskolodin I was on Rust stable? That may have been why? I have stable/beta/nightly all installed and I believe stable is default.

@therustmonk
Copy link
Member

@wldcordeiro Thank you! 👌 I think it's time to check all versions with travis :)

@therustmonk therustmonk mentioned this issue Dec 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@therustmonk @wldcordeiro