Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown #60

Closed
remexre opened this issue Dec 30, 2017 · 4 comments
Closed

Markdown #60

remexre opened this issue Dec 30, 2017 · 4 comments

Comments

@remexre
Copy link

remexre commented Dec 30, 2017

I've got a small module that uses Yew with pulldown-cmark to render a Markdown String to a VNode; would this be something you'd want to have bundled with yew (perhaps as an optional feature), or should it be a separate crate?

@therustmonk
Copy link
Member

Sounds cool! It's really interesting to to see how it works! Could you send us a link to your repository?
I think the better place for this kind of features are separate crates, because there are a lot of markups and it's more convenient to plug any you want from crates. Maybe I even will split Yew to the multiple crates in the future (for example: framework, virtual-dom and each service).

@remexre
Copy link
Author

remexre commented Jan 2, 2018

Right now it's just a module inside a larger project: https://github.com/acmumn/mentoring/blob/master/web-client/src/view/markdown.rs -- I'll probably publish after this crate goes on crates.io.

Currently, table headers are not th's (blocked on #67), and footnotes are not supported, but everything else I've thrown at it works.

@therustmonk
Copy link
Member

@remexre Don't you mind if I add a minimal markdown implementation to crm demo here #82 ? I want to use it as test case for building virtual dom manually.
If I put markdown example from here it renders correctly, but what do you think I have not taken into account to encounter the same issue?

@remexre
Copy link
Author

remexre commented Jan 8, 2018

Sounds good to me; I think table headers aren't being constructed properly and footnotes don't work.

@jstarry jstarry closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants