Add markdown rendering demo #82

therustmonk · 2018-01-05T10:18:38Z

This changes is an attempt to resolve #67
Also this PR add oninput event support to <textarea>.

koute · 2018-01-05T12:21:19Z

Cargo.toml

-stdweb = "0.3"
+#stdweb = "0.3"
+
+stdweb = { path = "../stdweb" }


FYI, in your .cargo/config in your home directory you can add this:

paths = [ "/path/with/your/local/checkout/stdweb" ]

And then cargo will use your local copy instead of the upstream one without you having to modify the Cargo.toml.

I was a little hasty about this change ) Great advice! And really much easier! 👍

vitiral

Really excited for this, definitely a requirement for Artifact 👍

vitiral · 2018-03-21T02:29:55Z

examples/crm/src/markdown.rs

@@ -0,0 +1,104 @@
+/// Original author of this code is [Nathan Ringo](https://github.com/remexre)


don't you think we should move this into a separate crate?

While I think this functionality is worth of it's own crate. I also believe that having it as part of the examples would make it easier for new people to the library (like me) to understand how to generate new dom elements that can be used within the html! macro.

So I do see the value of it in the examples. Is there any other place I can look for such documentation without having to dig into the implementation code?

that's a good point! It can be made it's own crate separately.

vitiral · 2018-03-21T02:32:00Z

src/html.rs

+            } else if let Ok::<TextAreaElement,_>(textarea) = this.clone().try_into() {
+                textarea.value()
+            } else {
+                panic!("only InputElement or TextAreaElement could have oninput event listener");


technically this should be unreachable! right?

vitiral · 2018-03-21T02:34:20Z

src/virtual_dom/vtag.rs

@@ -263,6 +263,19 @@ impl<MSG> VTag<MSG> {
            // IMPORTANT! This parameters have to be set every time
            // to prevent strange behaviour in browser when DOM changed
            set_checked(&input, self.checked);


do you think set_checked should be called for TextAreaElement as well?

Edit: probably not -- checked is for checkboxes associated with the overloaded <input> element.

vitiral · 2018-04-26T02:21:36Z

is there anything you need to move this forward?

I plan on using markdown + textarea elements in artifact very soon. I will probably be merging this branch locally and making any bugfixes there. Do you mind if I take over this PR?

vitiral · 2018-04-26T03:32:23Z

It looks like the TextAreaElement piece of this was already merged, correct? So it is just the markdown example remaining?

hgzimmerman · 2018-05-02T14:41:57Z

@vitiral I have a working implementation of markdown -> HTML rendering based on a more recent version of Yew. I can't guarantee that it works with Yew 0.4.x at this very moment, but if you want a reasonable place to start, then this file may be of use.
Its based on updated code from the original author that inspired this PR, the source of which can be found here.

I don't have time to work this into an example at the moment, so I encourage you to take the lead on this if you wish.

therustmonk · 2018-05-02T18:41:52Z

@vitiral @hgzimmerman I would really appreciate it if you could help me with that. I haven't enough time to complete it, because I want to stabilize the latest version of the framework.
If you have own implementation I could close this PR in favour of your. There is no special requirements to features. The main idea to show how to build own tree from scratch.

What about to create a separate crate for rendering markdown? Is this in demand? Or example is enough?

vitiral · 2018-05-02T21:26:56Z

I could not get pulldown_cmark to compile in wasm or emscripten so I just included the commonmark javascript library and used the js! macro to get the html, then Node::from_html and VRef::Node to insert it into my webapp. Works like a charm and is good enough for now IMO!

If you could get pulldown_cmark to compile you could still just use Node::from_html for now if you didn't want to do anything special (which you shouldn't be... it's markdown. What special stuff I do I do by replacing specialized markdown syntax with html).

@deniskolodin everything I need works great for me regarding this issue. I say feel free to close. I think a yew_markdown crate should totally happen, but I don't think the yew examples should necessarily include its implementation. Also, the ecosystem is a bit too unstable at the moment to have external dependencies like pulldown_cmark (these are just my opinions).

hgzimmerman · 2018-05-07T12:28:12Z

Sad to hear that you couldn't get pulldown_cmark to work, but glad to hear you found an alternative solution. I'm using a version of pulldown_cmark that points to a specific commit, likely from a while ago. A more recent version of that crate may not play well with WASM/JS targets.

I think there is demand for a yew-markdown crate, but given the current reliance on a non-published version of pulldown_cmark, it doesn't seem wise to invest the time in a separate crate before a known good WASM/JS compatible markdown parser is available. I think having an example for the moment is more than enough, but I will spend a little time investigating pulldown_cmark and other markdown parsing options in regards to web-compatibility.

I anticipate having some free time a week from now and will allocate some time towards getting an example built then.

Istar-Eldritch · 2018-05-12T13:07:17Z

That is strange to hear @vitiral I have a working version of pulldown_cmark pointing to the latest master branch here: https://github.com/Istar-Eldritch/personal-page/blob/master/src/markdown.rs

It's basically the same implementation you have here with slight moditifcations.

hgzimmerman · 2018-06-10T15:19:29Z

Hey, I just want to let you know that I haven't forgotten about this. In light of the forthcoming significant changes to the framework, I'm going to wait to open a PR for markdown rendering until your changes land.

hgzimmerman · 2018-06-22T11:52:50Z

#292 should now take precedence over this PR.

therustmonk · 2018-06-22T17:07:49Z

Closed in favour #292! Thank goes to @hgzimmerman 🎉

therustmonk added the in-progress label Jan 5, 2018

therustmonk mentioned this pull request Jan 5, 2018

Add TextAreaElement with value getter/setter koute/stdweb#69

Merged

koute reviewed Jan 5, 2018

View reviewed changes

Add description field to crm demo

e1cb8c9

therustmonk force-pushed the crm-markdown branch from d3013e5 to e1cb8c9 Compare January 5, 2018 13:16

Add a minimal markdown rendering implementation to crm demo

40b8770

therustmonk mentioned this pull request Jan 5, 2018

Markdown #60

Closed

therustmonk changed the title ~~Add description field to crm demo~~ Add markdown rendering demo Jan 5, 2018

therustmonk mentioned this pull request Jan 30, 2018

Tracking issue for 0.3.0 #93

Closed

8 tasks

vitiral reviewed Mar 21, 2018

View reviewed changes

therustmonk added the good first issue label May 2, 2018

therustmonk closed this Jun 22, 2018

therustmonk removed good first issue PR 🏗️ IN PROGRESS labels Jun 22, 2018

therustmonk deleted the crm-markdown branch August 11, 2019 13:11

Kingcrypto38 mentioned this pull request Jan 20, 2024

[Snyk] Upgrade clsx from 2.0.0 to 2.1.0 Kingcrypto38/yew#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add markdown rendering demo #82

Add markdown rendering demo #82

therustmonk commented Jan 5, 2018 •

edited

koute Jan 5, 2018

therustmonk Jan 5, 2018

vitiral left a comment

vitiral Mar 21, 2018

Istar-Eldritch Mar 30, 2018 •

edited

vitiral Apr 3, 2018

vitiral Mar 21, 2018

vitiral Mar 21, 2018 •

edited

vitiral commented Apr 26, 2018

vitiral commented Apr 26, 2018

hgzimmerman commented May 2, 2018

therustmonk commented May 2, 2018

vitiral commented May 2, 2018 •

edited

hgzimmerman commented May 7, 2018 •

edited

Istar-Eldritch commented May 12, 2018

hgzimmerman commented Jun 10, 2018

hgzimmerman commented Jun 22, 2018

therustmonk commented Jun 22, 2018

		@@ -0,0 +1,104 @@
		/// Original author of this code is [Nathan Ringo](https://github.com/remexre)

Add markdown rendering demo #82

Add markdown rendering demo #82

Conversation

therustmonk commented Jan 5, 2018 • edited

koute Jan 5, 2018

Choose a reason for hiding this comment

therustmonk Jan 5, 2018

Choose a reason for hiding this comment

vitiral left a comment

Choose a reason for hiding this comment

vitiral Mar 21, 2018

Choose a reason for hiding this comment

Istar-Eldritch Mar 30, 2018 • edited

Choose a reason for hiding this comment

vitiral Apr 3, 2018

Choose a reason for hiding this comment

vitiral Mar 21, 2018

Choose a reason for hiding this comment

vitiral Mar 21, 2018 • edited

Choose a reason for hiding this comment

vitiral commented Apr 26, 2018

vitiral commented Apr 26, 2018

hgzimmerman commented May 2, 2018

therustmonk commented May 2, 2018

vitiral commented May 2, 2018 • edited

hgzimmerman commented May 7, 2018 • edited

Istar-Eldritch commented May 12, 2018

hgzimmerman commented Jun 10, 2018

hgzimmerman commented Jun 22, 2018

therustmonk commented Jun 22, 2018

therustmonk commented Jan 5, 2018 •

edited

Istar-Eldritch Mar 30, 2018 •

edited

vitiral Mar 21, 2018 •

edited

vitiral commented May 2, 2018 •

edited

hgzimmerman commented May 7, 2018 •

edited