Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch service should support request headers #66

Closed
gabisurita opened this issue Dec 31, 2017 · 1 comment
Closed

Fetch service should support request headers #66

gabisurita opened this issue Dec 31, 2017 · 1 comment

Comments

@gabisurita
Copy link
Contributor

There should be a way to pass headers (e.g. Authrization, KeepAlive, etc) as part of the request using fetch.

IMO the most idiomatic way would be to expose a fetch constructor (instead of having the fetch method already performing the request) and allow to include the javascript fetch API arguments as methods. I can try to sketch a PR if you agree with this pattern.

@therustmonk therustmonk mentioned this issue Jan 1, 2018
4 tasks
@therustmonk
Copy link
Member

Thanks! It's resonable! I'm going to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants