Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed Request/Response objects in Fetch Service #95

Merged
merged 2 commits into from Jan 11, 2018
Merged

Use typed Request/Response objects in Fetch Service #95

merged 2 commits into from Jan 11, 2018

Conversation

gabisurita
Copy link
Contributor

@gabisurita gabisurita commented Jan 9, 2018 •
edited

Proposes the use of typed Request and Response objects as an interface for the Fetch API using the http crate.

Fixes #66 among other issues such as support for other HTTP methods (other than GET and POST), reading status codes and response headers.

@wldcordeiro
Copy link
Contributor

This looks awesome. It's great to use something that has a focus on its domain to allow yew to handle things it's good at.

@therustmonk
Copy link
Member

therustmonk commented Jan 10, 2018 •
edited

@gabisurita Thank you! I like this PR, this is the smart improvement 👍
Don't you mind that I've rebased it to master 41e637f (instead of merge to remove one unnecessary commit)?

@therustmonk therustmonk changed the title [Proposal] Use typed Request/Response objects in Fetch Service Use typed Request/Response objects in Fetch Service Jan 10, 2018
@gabisurita
Copy link
Contributor Author

@deniskolodin No problem. I'll close the PR them. Tks!

@gabisurita gabisurita closed this Jan 10, 2018
@gabisurita gabisurita deleted the typed-fetch branch January 10, 2018 17:49
@wldcordeiro
Copy link
Contributor

There was no need to close! @gabisurita I think there was a misunderstanding. When @deniskolodin rebased your branch he changed the commit history to be only the two commits you made and not the three including the generated one for merging master. I believe it still needs to be merged.

@therustmonk
Copy link
Member

@gabisurita This PR is good! You shouldn't close it! I tried to found out if I can remove the redundant commit. I still want to merge it. Could you reopen it, please? =)

@gabisurita gabisurita restored the typed-fetch branch January 11, 2018 09:33
@gabisurita
Copy link
Contributor Author

gabisurita commented Jan 11, 2018 •
edited

Sure. Now I've got what happened. Thought you have merged it into master. I can rebase It later as well to get rid of the extra commit.

@gabisurita gabisurita reopened this Jan 11, 2018
@therustmonk therustmonk merged commit 5071dd0 into yewstack:master Jan 11, 2018
@therustmonk
Copy link
Member

@gabisurita I've merged it 👍 Thank you!

@anykao anykao mentioned this pull request Jan 12, 2018
Closed
@gabisurita gabisurita deleted the typed-fetch branch January 15, 2018 00:52
teymour-aldridge referenced this pull request in teymour-aldridge/yew Jul 8, 2020
@amorriscode
Add latest Stack Overflow survey results (#95)
9594b47
jstarry pushed a commit to jstarry/yew that referenced this pull request Jul 10, 2020
@amorriscode @jstarry
Add latest Stack Overflow survey results (yewstack#95)
c5266f7
jstarry added a commit that referenced this pull request Jul 10, 2020
@jstarry @teymour-aldridge
@D4nte @ETCaton @drpoggi @lili668668 @mkawalec @codec-abc @amorriscode @zoechi @darrenmeehan @dirkpuge @hituzi-no-sippo @Mingun @FIGBERT
Migrate remaining docs (#1399)
e7e3ebd 
* GitBook: [master] 2 pages modified

* Added code examples for the router docs. (#67)

* GitBook: [master] 3 pages modified

* GitBook: [master] one page modified

* Update the sample doc app to use wasm-pack (#75)

* Update the sample doc app to use wasm-pack

According to the rest of the documentation, wasm-pack and web-sys are
the recommended tool to use. However, the sample app documents the usage
of cargo-web and stdweb.

The command lines are taken from the example folder of yew.

* Some grammar fixes

* Use cargo miniserve instead of python to server the files

* Add wasm-bindgen dependency

* Fixed bad link to build script for wasm-bindgen/cargo-web (#81)

* Fixed bad link to build script for wasm-bindgen/cargo-web

* yewstack/docs#81 Updated link for cargo-web

* Update miniserve cargo install command (#88)

* create as lib right away (#93)

* updated (#92)

* GitBook: [master] 29 pages modified

* update the docs to specify that local agents do not incur serialization overhead (#89)

* Add a note telling how to bypass the recursion limit of the html! macro. (#94)

* Add a note telling how to bypass the recursion limit of the html! macro.

* Update src/concepts/html/README.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Update src/concepts/html/README.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Add latest Stack Overflow survey results (#95)

* Mention prop_or macro (#97)

* Mention prop_or macro

* Fix the prop_or vs prop_or_else mixup

* Update src/concepts/components/properties.md

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Fix a typo. (#102)

* Point to master branch for examples (#98)

* Point to master branch for examples

* Update src/getting-started/examples.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Update src/getting-started/examples.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Add code of conduct to documentation as well. (#104)

* Added "" for the version at line 25 (#107)

* Added "" for the version at line 25

* Update src/getting-started/starter-templates.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Removed periods and fixed spelling mistakes (#103)

* Added period to description

* Fixed the spelling of " Arguabley" to "Arguably"

* Update README.md

* Added period to description

* Added period to description

* Grammar and spelling correction

added period to description, fixed spelling of "encouter" to "encounter"

* Added period to description

* Added period to description

* Grammar and spelling

Added period to description, fixed spelling of "accross" to "across"

* Added period to description

* Added period to description

* Fixed spelling of "aggresive" to "aggressive"

* Removed period from description

* Update optimizations.md

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Removed period from description

* Update src/concepts/html/README.md

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Shorten line lengths. (#106)

* Shortens line lengths (to ~100 characters max per line).
 * A few stylistic improvements
 * Corrects a couple of typos
 * Fixes a few grammar errors

Co-authored-by: Justin Starry <justin.starry@icloud.com>

* bumping up the yew version in Cargo.toml (#107) (#109)

* bumping up the yew version in Cargo.toml (#107)

* bumping up the yew version for stdweb

* bumping up the yew version of ConsoleService link

* bumping up the yew version

* Update src/more/debugging.md

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>

* Add #[derive(Clone)] in examples (#111)

* Add #[derive(Clone)] in examples

Closes #110

* Add backticks to rust elements

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Another backtics

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>

* Fix typo (#112)

* GitBook: [master] 29 pages modified

* Fix spellcheck

* Remove duplicate code of conduct

Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
Co-authored-by: Franck Royer <royer.franck@gmail.com>
Co-authored-by: Eamon Caton <etcaton@gmail.com>
Co-authored-by: David Poggi <drpoggi@users.noreply.github.com>
Co-authored-by: Stephan Dilly <dilly.stephan@gmail.com>
Co-authored-by: 洪慈吟 <lili668668@gmail.com>
Co-authored-by: Michal Kawalec <michal@monad.cat>
Co-authored-by: codec-abc <viot.camille@outlook.com>
Co-authored-by: Anthony Morris <anthony@amorrissound.com>
Co-authored-by: Günter Zöchbauer <guenter@gzoechbauer.com>
Co-authored-by: Darren Meehan <Darrenmeehan@users.noreply.github.com>
Co-authored-by: Nougator <37145431+nougator@users.noreply.github.com>
Co-authored-by: Dirk Puge <67125647+dirkpuge@users.noreply.github.com>
Co-authored-by: hituzi no sippo <43565959+hituzi-no-sippo@users.noreply.github.com>
Co-authored-by: Mingun <Alexander_Sergey@mail.ru>
Co-authored-by: FIGBERT <figbert@figbert.com>
jstarry pushed a commit that referenced this pull request Jul 10, 2020
@amorriscode @jstarry
Add latest Stack Overflow survey results (#95)
f7b44db
jstarry pushed a commit that referenced this pull request Aug 16, 2020
@amorriscode @jstarry
Add latest Stack Overflow survey results (#95)
03ead3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therustmonk therustmonk therustmonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabisurita @wldcordeiro @therustmonk