Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input current value sync #1268

Merged
merged 4 commits into from
May 28, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions yew/src/virtual_dom/vtag.rs
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,27 @@ impl VDiff for VTag {
if self.tag == vtag.tag {
// If tags are equal, preserve the reference that already exists.
self.reference = vtag.reference.take();
if let Some(element) = self.reference.as_ref() {
if let Some(input) = {
cfg_match! {
feature = "std_web" => InputElement::try_from(element.clone()).ok(),
feature = "web_sys" => element.dyn_ref::<InputElement>(),
}
} {
let current_value = cfg_match! {
feature = "std_web" => input.raw_value(),
feature = "web_sys" => input.value(),
};
vtag.set_value(&current_value)
} else if let Some(tae) = {
cfg_match! {
feature = "std_web" => TextAreaElement::try_from(element.clone()).ok(),
feature = "web_sys" => element.dyn_ref::<TextAreaElement>(),
}
} {
vtag.set_value(&tae.value())
}
}
(Reform::Keep, Some(vtag))
} else {
// We have to create a new reference, remove ancestor.
Expand Down Expand Up @@ -1196,6 +1217,72 @@ mod tests {
);
}

#[test]
fn check_input_current_value_sync() {
let scope = test_scope();
let parent = document().create_element("div").unwrap();

#[cfg(feature = "std_web")]
document().body().unwrap().append_child(&parent);
#[cfg(feature = "web_sys")]
document().body().unwrap().append_child(&parent).unwrap();

let expected = "not_changed_value";

// Initial state
let mut elem = html! {
<input value=expected />
};
elem.apply(&scope, &parent, None, None);

let vtag = if let VNode::VTag(vtag) = elem {
vtag
} else {
panic!("should be vtag")
};

// User input
let input_ref = vtag.reference.as_ref().unwrap();
let input = cfg_match! {
feature = "std_web" => InputElement::try_from(input_ref.clone()).ok(),
feature = "web_sys" => input_ref.dyn_ref::<InputElement>(),
};
cfg_match! {
feature = "std_web" => input.unwrap().set_raw_value("User input"),
feature = "web_sys" => input.unwrap().set_value("User input"),
};

let ancestor = vtag;
// Same state after onInput or onChange event
let elem = html! {
<input value=expected />
};
let mut vtag = if let VNode::VTag(vtag) = elem {
vtag
} else {
panic!("should be vtag")
};

// Sync happens here
vtag.apply(&scope, &parent, None, Some(VNode::VTag(ancestor)));

// Get new current value of the input element
let input_ref = vtag.reference.as_ref().unwrap();
let input = cfg_match! {
feature = "std_web" => InputElement::try_from(input_ref.clone()).ok(),
feature = "web_sys" => input_ref.dyn_ref::<InputElement>(),
}
.unwrap();

let current_value = cfg_match! {
feature = "std_web" => input.raw_value(),
feature = "web_sys" => input.value(),
};

// check whether not changed virtual dom value has been set to the input element
assert_eq!(current_value, expected);
}

#[test]
fn dynamic_tags_work() {
let scope = test_scope();
Expand Down