Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an input to self #1278

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Send an input to self #1278

merged 2 commits into from
Jun 20, 2020

Conversation

mkawalec
Copy link
Contributor

@mkawalec mkawalec commented Jun 1, 2020

A pattern I keep on needing in the ability to trigger an action while handling another action in an agent. This adds the ability of sending another input message while handling an input message.

@jstarry
Copy link
Member

jstarry commented Jun 8, 2020

@mkawalec I'm not super opposed to this change but I'm curious, why not send a message instead? Is it to avoid duplicating code?

@jstarry jstarry added this to In progress in Pain Point: Agents via automation Jun 8, 2020
@mkawalec
Copy link
Contributor Author

@jstarry In the Store pattern I have it wired in such a way that Inputs are actions that we want to execute and Messages carry action results to reducers. I would have to make the code a bit awkward and handle 'messages that actually want to trigger actions' in the reducers (thus mixing concerns) instead of cleanly invoking new actions with Inputs.

@jstarry
Copy link
Member

jstarry commented Jun 20, 2020

Got it, I could see there being awkwardness there

@jstarry jstarry merged commit 8d78620 into yewstack:master Jun 20, 2020
Pain Point: Agents automation moved this from In progress to Done Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants