Implement Deref<Target=str> for Key #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess tests are not necessary. |
| impl Deref for Key { | ||
| type Target = str; | ||
|
|
||
| #[inline] |
There was a problem hiding this comment.
What is the advantage of inlining this?
There was a problem hiding this comment.
Don't know what I was thinking, but at least it's also in std::Strings impl marked as inline. Should I remove it?
There was a problem hiding this comment.
I guess explicitly inlining this might make LLVM do some more optimization work, but I don't think it really matters.
|
IMO it would be nice (but not essential) to have a test for this. |
|
Looks good to me! I agree that tests aren't essential and the inline is fine |
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
Co-authored-by: Urs Schulz <github@ursschulz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1369
Checklist:
./ci/run_stable_checks.sh