Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow web worker resource to be relative #2086

Merged
merged 8 commits into from Nov 20, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/yew-agent/src/lib.rs
Expand Up @@ -53,6 +53,11 @@ pub trait Agent: Sized + 'static {
"main.js"
}

/// Indicates whether the name of the resource is relative.
fn name_of_resource_is_relative() -> bool {
astraw marked this conversation as resolved.
Show resolved Hide resolved
false
}

/// Signifies if resource is a module.
/// This has pending browser support.
fn is_module() -> bool {
Expand Down
48 changes: 45 additions & 3 deletions packages/yew-agent/src/worker/mod.rs
Expand Up @@ -70,10 +70,23 @@ where
worker.post_message_vec(msg);
}

fn worker_new(name_of_resource: &str, is_module: bool) -> Worker {
fn worker_new(name_of_resource: &str, name_is_relative: bool, is_module: bool) -> Worker {
astraw marked this conversation as resolved.
Show resolved Hide resolved
let origin = yew::utils::origin().unwrap();
let script_url = format!("{}/{}", origin, name_of_resource);
let wasm_url = format!("{}/{}", origin, name_of_resource.replace(".js", "_bg.wasm"));
let pathname = yew::utils::window().location().pathname().unwrap();

let prefix = if name_is_relative {
astraw marked this conversation as resolved.
Show resolved Hide resolved
// Location pathname always contains initial '/', so unwrap will never fail.
pathname.revsplit_once('/').unwrap().0
} else {
""
};
astraw marked this conversation as resolved.
Show resolved Hide resolved
let script_url = format!("{}{}/{}", origin, prefix, name_of_resource);
let wasm_url = format!(
"{}{}/{}",
origin,
prefix,
name_of_resource.replace(".js", "_bg.wasm")
);
let array = Array::new();
array.push(
&format!(
Expand Down Expand Up @@ -107,6 +120,35 @@ fn worker_self() -> DedicatedWorkerGlobalScope {
JsValue::from(js_sys::global()).into()
}

trait RevSplitOnce {
/// Splits the string on the last occurrence of the specified delimiter and
/// returns prefix before delimiter and suffix after delimiter.
///
/// Behaves identically to `rsplit_once` introduced with rust 1.52 but is
/// available prior to 1.52.
fn revsplit_once(&self, delimiter: char) -> Option<(&str, &str)>;
}

impl RevSplitOnce for str {
fn revsplit_once<'a>(&'a self, delimiter: char) -> Option<(&'a str, &'a str)> {
let components: Vec<&'_ str> = self.rsplitn(2, delimiter).collect();
assert!(components.len() < 3);
if components.len() == 2 {
Some((components[1], components[0]))
} else {
None
}
}
}

#[test]
fn test_rsplit_once() {
// These from the docstrings in rsplit_once.
assert_eq!("cfg".revsplit_once('='), None);
assert_eq!("cfg=foo".revsplit_once('='), Some(("cfg", "foo")));
assert_eq!("cfg=foo=bar".revsplit_once('='), Some(("cfg=foo", "bar")));
}

trait WorkerExt {
fn set_onmessage_closure(&self, handler: impl 'static + Fn(Vec<u8>));

Expand Down
3 changes: 2 additions & 1 deletion packages/yew-agent/src/worker/private.rs
Expand Up @@ -54,11 +54,12 @@ where
};

let name_of_resource = AGN::name_of_resource();
let is_relative = AGN::name_of_resource_is_relative();
astraw marked this conversation as resolved.
Show resolved Hide resolved
let handler_cell = Rc::new(RefCell::new(Some(handler)));

let worker = {
let handler_cell = handler_cell.clone();
let worker = worker_new(name_of_resource, AGN::is_module());
let worker = worker_new(name_of_resource, is_relative, AGN::is_module());
let worker_clone = worker.clone();
worker.set_onmessage_closure(move |data: Vec<u8>| {
if let Some(handler) = handler_cell.borrow().as_ref() {
Expand Down
3 changes: 2 additions & 1 deletion packages/yew-agent/src/worker/public.rs
Expand Up @@ -64,8 +64,9 @@ where
}
};
let name_of_resource = AGN::name_of_resource();
let is_relative = AGN::name_of_resource_is_relative();
astraw marked this conversation as resolved.
Show resolved Hide resolved
let worker = {
let worker = worker_new(name_of_resource, AGN::is_module());
let worker = worker_new(name_of_resource, is_relative, AGN::is_module());
let worker_clone = worker.clone();
worker.set_onmessage_closure(move |data: Vec<u8>| {
handler(data, &worker_clone);
Expand Down