Wasm doc tests #2651
Wasm doc tests #2651
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
See #2651 (comment) |
|
Visit the preview URL for this PR (updated for commit 57004dc): https://yew-rs--pr2651-wasm-doc-tests-1oxkqqrv.web.app (expires Sun, 08 May 2022 18:56:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
.github/workflows/main-checks.yml
Outdated
| with: | ||
| path: "./wasm-bindgen" | ||
| ref: respect-rustdoc-tmp-paths | ||
| repository: hamza1311/wasm-bindgen | ||
|
|
||
| - uses: Swatinem/rust-cache@v1 | ||
|
|
||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| target: wasm32-unknown-unknown | ||
| override: true | ||
| profile: minimal | ||
|
|
||
| - uses: Swatinem/rust-cache@v1 | ||
| - run: | | ||
| cd wasm-bindgen | ||
| cargo build -p wasm-bindgen-cli --bin wasm-bindgen-test-runner --release | ||
| cp target/release/wasm-bindgen-test-runner ~/.cargo/bin/wasm-bindgen-test-runner |
There was a problem hiding this comment.
This is the best solution I have until rustwasm/wasm-bindgen#2881 is merged and published. I tried building wasm-bindgen-test-runner on my local computer and putting it in ci directory but it won't run because it's not built with musl and I can't get a musl build to work locally
|
Why is the benchmark check failing? |
It seems that some tests are not being in a headless version of chrome. Could it have something to do with krausest/js-framework-benchmark@a92354a? At least I think that (re)enabled the tests we see failing. |
If that's the case then it should be fixed when this PR is merged. I made it pull a specific commit until krausest/js-framework-benchmark#1032 is resolved |
This reverts commit c32ad82. This should be no longer needed: krausest/js-framework-benchmark#1032 (comment)
Description
Run doc tests in CI on wasm32-unknown-unknown target and on nightly toolchain
Fixes #2503
Checklist