Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tokio to 1.20.1 to fix CI #2866

Merged
merged 1 commit into from Sep 10, 2022

Conversation

hamza1311
Copy link
Member

@hamza1311 hamza1311 commented Sep 10, 2022

Description

This is a temporary work around for tokio-rs/tokio#4973

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ce09802):

https://yew-rs-api--pr2866-pin-to-working-tokio-mhstz0tw.web.app

(expires Sat, 17 Sep 2022 20:40:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 170.268 N/A N/A N/A
contexts 107.848 N/A N/A N/A
counter 85.501 N/A N/A N/A
counter_functional 86.031 N/A N/A N/A
dyn_create_destroy_apps 88.399 N/A N/A N/A
file_upload 100.081 N/A N/A N/A
function_memory_game 163.805 N/A N/A N/A
function_router 348.476 N/A N/A N/A
function_todomvc 158.626 N/A N/A N/A
futures 222.372 N/A N/A N/A
game_of_life 105.767 N/A N/A N/A
immutable 181.604 N/A N/A N/A
inner_html 82.369 N/A N/A N/A
js_callback 111.374 N/A N/A N/A
keyed_list 195.569 N/A N/A N/A
mount_point 85.121 N/A N/A N/A
nested_list 112.598 N/A N/A N/A
node_refs 92.854 N/A N/A N/A
password_strength 1549.015 N/A N/A N/A
portals 96.283 N/A N/A N/A
router 318.140 N/A N/A N/A
simple_ssr 152.177 N/A N/A N/A
ssr_router 394.047 N/A N/A N/A
suspense 109.166 N/A N/A N/A
timer 88.343 N/A N/A N/A
todomvc 139.743 N/A N/A N/A
two_apps 86.114 N/A N/A N/A
web_worker_fib 152.228 N/A N/A N/A
webgl 84.835 N/A N/A N/A

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 345.431 346.377 345.922 0.344
Hello World 10 619.933 628.781 620.995 2.741
Function Router 10 2286.893 2301.689 2292.088 4.159
Concurrent Task 10 1008.159 1009.803 1009.066 0.480

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 353.412 356.072 354.643 0.928
Hello World 10 621.792 624.364 622.958 1.098
Function Router 10 2292.341 2310.624 2303.053 4.715
Concurrent Task 10 1007.690 1009.483 1008.639 0.581

@futursolo futursolo merged commit a489690 into yewstack:master Sep 10, 2022
@Darksonn
Copy link

This should have been fixed in v1.21.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants