New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy::let_unit_value lint in propless components #2970
Conversation
Visit the preview URL for this PR (updated for commit 0c6238b): https://yew-rs-api--pr2970-fix-unit-let-fm2m2jbt.web.app (expires Sat, 26 Nov 2022 12:46:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
@Starwort I think this should be enough to fix the clippy lints. We don't have an automated test for these lints setup, so do you mind manually testing it. At least with today's 1.67 nightly clippy, the reproduction from the bug report doesn't show any warnings for me. |
I tried replacing, in If you can tell me steps to repair the build, I'd be happy to post updated results; if you'd like to just run it on my codebase, the project in question is https://github.com/Starwort/gear-miner/ (the lint is disabled globally in |
It's taking a bit longer, because the app would have to be converted to yew's git version. Should not require any changes to component logic, but a few extra |
The openssl errors are unrelated to this change. This PR looks good so I'm going to go ahead and merge it |
Description
Fixes #2931
Checklist
I can't figure out how to run clippy lints as part of the try_build macro tests. Any tip is appreciated. Otherwise, we'd have to setup another test rig just for clippy.