Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions #2998

Merged
merged 4 commits into from Dec 4, 2022
Merged

Update GitHub Actions #2998

merged 4 commits into from Dec 4, 2022

Conversation

futursolo
Copy link
Member

@futursolo futursolo commented Dec 3, 2022

Description

GitHub Actions will soon deprecate Node.js 12 Actions.
actions-rs/* actions are still using Node.js 12 and haven't received any updates for more than a year.

This pull request replaces them with dtolnay/rust-toolchain and run.

This pull request also enables dependabot for GitHub Actions which should phase out remaining Node.js 12 actions by merging the pull request dependabot creates.

Checklist

  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Dec 3, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 3, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Visit the preview URL for this PR (updated for commit 7f2bd69):

https://yew-rs-api--pr2998-update-ci-jsihgjil.web.app

(expires Sat, 10 Dec 2022 19:28:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 456.008 476.499 463.501 7.605
Hello World 10 776.353 794.920 784.590 5.803
Function Router 10 2910.859 2980.148 2952.436 20.302
Concurrent Task 10 1009.233 1011.389 1010.776 0.694

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 401.073 417.179 408.045 5.428
Hello World 10 784.426 816.253 797.254 11.808
Function Router 10 2978.213 3075.983 3016.003 30.931
Concurrent Task 10 1010.056 1018.614 1011.863 2.435

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 108.311 108.311 0 0.000%
boids 172.395 172.384 -0.011 -0.006%
communication_child_to_parent 92.444 92.446 +0.002 +0.002%
communication_grandchild_with_grandparent 106.925 106.920 -0.005 -0.005%
communication_grandparent_to_grandchild 102.775 102.770 -0.006 -0.006%
communication_parent_to_child 89.536 89.532 -0.004 -0.004%
contexts 109.494 109.482 -0.012 -0.011%
counter 87.450 87.449 -0.001 -0.001%
counter_functional 87.864 87.861 -0.003 -0.003%
dyn_create_destroy_apps 90.301 90.301 0 0.000%
file_upload 101.771 101.770 -0.002 -0.002%
function_memory_game 165.399 165.401 +0.002 +0.001%
function_router 350.140 350.136 -0.004 -0.001%
function_todomvc 160.077 160.072 -0.005 -0.003%
futures 224.433 224.432 -0.001 -0.000%
game_of_life 107.082 107.080 -0.002 -0.002%
immutable 184.155 184.154 -0.001 -0.001%
inner_html 83.872 83.869 -0.003 -0.003%
js_callback 113.152 113.146 -0.007 -0.006%
keyed_list 197.890 197.892 +0.002 +0.001%
mount_point 87.016 87.018 +0.002 +0.002%
nested_list 114.013 114.008 -0.005 -0.004%
node_refs 94.960 94.951 -0.009 -0.009%
password_strength 1552.821 1552.822 +0.001 +0.000%
portals 98.232 98.230 -0.002 -0.002%
router 320.279 320.270 -0.010 -0.003%
simple_ssr 153.715 153.720 +0.005 +0.003%
ssr_router 395.098 395.069 -0.028 -0.007%
suspense 110.826 110.824 -0.002 -0.002%
timer 90.345 90.343 -0.002 -0.002%
todomvc 141.354 141.354 -0.001 -0.001%
two_apps 88.074 88.072 -0.002 -0.002%
web_worker_fib 154.443 154.442 -0.001 -0.001%
webgl 86.596 86.595 -0.001 -0.001%

✅ None of the examples has changed their size significantly.

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. It seems often when one needs some tool, dtolnay has one ready 😆

@futursolo futursolo merged commit 5ca9129 into yewstack:master Dec 4, 2022
@futursolo futursolo deleted the update-ci branch December 15, 2022 10:11
WorldSEnder pushed a commit to WorldSEnder/yew that referenced this pull request Mar 18, 2023
* Update Workflow.

* Fix Workflows.

* Enables dependabot for github actions.

* Fix workflow.
WorldSEnder pushed a commit to WorldSEnder/yew that referenced this pull request Mar 18, 2023
* Update Workflow.

* Fix Workflows.

* Enables dependabot for github actions.

* Fix workflow.
hamza1311 pushed a commit that referenced this pull request Mar 19, 2023
* Update Workflow.

* Fix Workflows.

* Enables dependabot for github actions.

* Fix workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants