Update benchmark crates and workflow #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
this doesn't comment on PR directly, still benchmark-action/github-action-benchmark has open issues about it
hamza1311
approved these changes
Dec 11, 2022
I think we have to delete the data from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the benchmark setup to the latest
js-framework-benchmarksetup.Also separates the posting of comments and the update to the gh-pages branch to run the benchmarking with less priviledges.
When reviewing, pay most attention to .github/workflows/post-benchmark.yml as that workflow is not run as part of the PR (on purpose as it has elevated privileges).
Checklist