New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve grammar in website/docs #3092
Conversation
Visit the preview URL for this PR (updated for commit ca93c83): https://yew-rs--pr3092-master-eol2v4yf.web.app (expires Mon, 30 Jan 2023 11:59:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
It should have taken you a long time if you haven't used any automated grammar checker.
Some comments are not about the fixes but the original content itself.
I think it might be better to address them together in this pull request.
website/docs/advanced-topics/struct-components/introduction.mdx
Outdated
Show resolved
Hide resolved
8cb79e1
to
cfb089e
Compare
Thanks for looking at it @futursolo, I added your changes to a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to go through the docs and improving them. Really appreciate the effort ❤️
I skimmed though and the changes look good. I'm going off of @futursolo's review and approving it.
If anything comes up, it can be fixed in a future PR, of course.
Description
Improve grammar on the documentation website.
Checklist