Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar in website/docs #3092

Merged
merged 2 commits into from Feb 1, 2023
Merged

Improve grammar in website/docs #3092

merged 2 commits into from Feb 1, 2023

Conversation

jsjolund
Copy link
Contributor

Description

Improve grammar on the documentation website.

Checklist

  • I have reviewed my own code

@github-actions
Copy link

github-actions bot commented Jan 22, 2023

Visit the preview URL for this PR (updated for commit ca93c83):

https://yew-rs--pr3092-master-eol2v4yf.web.app

(expires Mon, 30 Jan 2023 11:59:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

It should have taken you a long time if you haven't used any automated grammar checker.

Some comments are not about the fixes but the original content itself.
I think it might be better to address them together in this pull request.

website/docs/advanced-topics/server-side-rendering.md Outdated Show resolved Hide resolved
website/docs/advanced-topics/server-side-rendering.md Outdated Show resolved Hide resolved
website/docs/concepts/basic-web-technologies/css.mdx Outdated Show resolved Hide resolved
website/docs/getting-started/introduction.mdx Outdated Show resolved Hide resolved
website/docs/more/debugging.mdx Outdated Show resolved Hide resolved
website/docs/more/debugging.mdx Outdated Show resolved Hide resolved
website/docs/tutorial/index.mdx Outdated Show resolved Hide resolved
website/docs/tutorial/index.mdx Outdated Show resolved Hide resolved
@jsjolund jsjolund force-pushed the master branch 2 times, most recently from 8cb79e1 to cfb089e Compare January 23, 2023 11:43
@jsjolund
Copy link
Contributor Author

Thanks for looking at it @futursolo, I added your changes to a commit.

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to go through the docs and improving them. Really appreciate the effort ❤️

I skimmed though and the changes look good. I'm going off of @futursolo's review and approving it.

If anything comes up, it can be fixed in a future PR, of course.

@hamza1311 hamza1311 merged commit 9556266 into yewstack:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants