New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index of Examples Fixes and Changes #3186
Conversation
- Added all communication examples - Reordered into alphabetical order to match the examples directory - Added `ssr_router` to the list - Added `function_router` to the list - Unified full stop usage
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken the liberty to check for spelling of other descriptions and add some suggestions for improvements there. Might as well. Thanks for the contribution!
Co-authored-by: WorldSEnder <WorldSEnder@users.noreply.github.com>
Co-Authored-By: WorldSEnder <WorldSEnder@users.noreply.github.com>
I've added the changes you mentioned, ready for your review again. 😄 |
Co-Authored-By: WorldSEnder <WorldSEnder@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! If some other reviewer has suggestions for the legend of "S", "F" and "SF", I'm open to ideas ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request!
Description
This PR fixes and changes the following in the
README.md
of the examples directory:ssr_router
to indexfunction_router
to indexMore explicit breakdowns are available in each individual commit.
Checklist
The checklist item for additional tests has been omitted as they are not necessary in this situation.