doc: use a more friendly link to codemod tool #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futursolo
approved these changes
May 11, 2023
WorldSEnder
approved these changes
May 11, 2023
|
Thank Yew team! Let me know if you need anything from me to retry the GH action! 😃 |
|
I guess the deployment of the website preview has decided to run forever. In any case, the PR is simple enough for me to merge as-is without further feedback from the pre-deploy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi yew team, I’m the author of the ast-grep, the tool you mentioned in migration guide.
You have done an amazing job with yew! It is one of the most innovative and impressive Rust web frameworks I have ever seen. I’m thrilled to see that ast-grep could help you. It’s my very design goal to make it easier for OSS teams to manage API changes and code migration and I’m glad you find it useful. Really appreciate your support and trust! 🥰
I noticed that you are linking to the crates.io page of the ast-grep in your README.md file. While this is a valid link, I would like to suggest changing the link to the official website of ast-grep. The official website includes a more detailed description of the tool, as well as installation instructions and usage examples. The crates.io page is more suitable for developers who want to install or depend on ast-grep as a library. It also looks less professional and trustworthy than the official website to the end users.
I hope this PR will help yew users to migrate the framework with fewer concerns. Thank you for your time and consideration!
Checklist