Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to pass state through a link. #3358

Merged
merged 3 commits into from Aug 14, 2023
Merged

Added the ability to pass state through a link. #3358

merged 3 commits into from Aug 14, 2023

Conversation

tikitko
Copy link
Contributor

@tikitko tikitko commented Jul 23, 2023

Description

Added the ability to pass state through a link.

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Jul 23, 2023

Visit the preview URL for this PR (updated for commit eb6d6b1):

https://yew-rs-api--pr3358-master-o6q1wxy4.web.app

(expires Sat, 19 Aug 2023 09:30:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Jul 23, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.402 102.402 0 0.000%
boids 175.562 175.562 0 0.000%
communication_child_to_parent 95.218 95.218 0 0.000%
communication_grandchild_with_grandparent 108.896 108.896 0 0.000%
communication_grandparent_to_grandchild 105.537 105.537 0 0.000%
communication_parent_to_child 92.698 92.698 0 0.000%
contexts 110.884 110.884 0 0.000%
counter 89.209 89.209 0 0.000%
counter_functional 89.925 89.925 0 0.000%
dyn_create_destroy_apps 92.235 92.235 0 0.000%
file_upload 103.542 103.542 0 0.000%
function_memory_game 174.360 174.360 0 0.000%
function_router 348.171 352.355 +4.185 +1.202%
function_todomvc 163.345 163.345 0 0.000%
futures 227.708 227.708 0 0.000%
game_of_life 112.351 112.351 0 0.000%
immutable 188.933 188.933 0 0.000%
inner_html 86.015 86.015 0 0.000%
js_callback 112.991 112.991 0 0.000%
keyed_list 201.201 201.201 0 0.000%
mount_point 89.206 89.206 0 0.000%
nested_list 114.496 114.496 0 0.000%
node_refs 96.166 96.166 0 0.000%
password_strength 1583.156 1583.156 0 0.000%
portals 98.236 98.236 0 0.000%
router 314.292 318.348 +4.056 +1.290%
simple_ssr 143.624 143.624 0 0.000%
ssr_router 385.408 389.541 +4.133 +1.072%
suspense 110.177 110.177 0 0.000%
timer 91.808 91.808 0 0.000%
timer_functional 100.320 100.320 0 0.000%
todomvc 143.695 143.695 0 0.000%
two_apps 89.917 89.917 0 0.000%
web_worker_fib 154.520 154.520 0 0.000%
webgl 88.476 88.476 0 0.000%

⚠️ The following examples have changed their size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
function_router 348.171 352.355 +4.185 +1.202%
router 314.292 318.348 +4.056 +1.290%
ssr_router 385.408 389.541 +4.133 +1.072%

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikitko

I think this pull request looks good.

We will be publishing a new version of Yew soon.
If you wish to include this change in the next release, please update the pull request and mark it as ready for review.

packages/yew-router/src/components/link.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 12, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 338.892 339.992 339.390 0.336
Hello World 10 624.397 635.644 630.483 3.710
Function Router 10 2002.854 2014.520 2006.963 3.627
Concurrent Task 10 1006.777 1008.374 1007.747 0.566
Many Providers 10 1433.341 1445.321 1439.785 4.238

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 339.218 339.790 339.485 0.190
Hello World 10 620.026 622.771 620.830 0.981
Function Router 10 2004.542 2011.993 2008.445 2.647
Concurrent Task 10 1006.741 1008.582 1007.899 0.554
Many Providers 10 1426.180 1455.059 1434.860 9.278

@tikitko tikitko marked this pull request as ready for review August 12, 2023 09:43
@tikitko
Copy link
Contributor Author

tikitko commented Aug 12, 2023

@tikitko

I think this pull request looks good.

We will be publishing a new version of Yew soon. If you wish to include this change in the next release, please update the pull request and mark it as ready for review.

Thx for review @futursolo !
PR updated.

@tikitko tikitko requested a review from futursolo August 12, 2023 09:44
Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@futursolo futursolo enabled auto-merge (squash) August 14, 2023 12:08
Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@futursolo futursolo merged commit 46bbb0c into yewstack:master Aug 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants