Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep checked attribute for elements without special handling #3373

Merged
merged 3 commits into from Aug 11, 2023

Conversation

hamza1311
Copy link
Member

Description

Input and textarea elements are handled specially. html! macro popped checked attribute for every element but did not return it if the element was one without special handling. This PR fixes that

Fixes #3189

Checklist

  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added the A-yew Area: The main yew crate label Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Visit the preview URL for this PR (updated for commit 50590ea):

https://yew-rs-api--pr3373-keep-checked-ssq9ptrv.web.app

(expires Wed, 16 Aug 2023 20:33:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.317 102.317 0 0.000%
boids 175.509 175.509 0 0.000%
communication_child_to_parent 95.225 95.225 0 0.000%
communication_grandchild_with_grandparent 108.892 108.892 0 0.000%
communication_grandparent_to_grandchild 105.545 105.545 0 0.000%
communication_parent_to_child 92.694 92.694 0 0.000%
contexts 110.885 110.885 0 0.000%
counter 89.206 89.206 0 0.000%
counter_functional 89.925 89.925 0 0.000%
dyn_create_destroy_apps 92.235 92.235 0 0.000%
file_upload 103.544 103.544 0 0.000%
function_memory_game 174.305 174.305 0 0.000%
function_router 347.826 347.826 0 0.000%
function_todomvc 163.350 163.350 0 0.000%
futures 227.710 227.710 0 0.000%
game_of_life 112.299 112.299 0 0.000%
immutable 188.946 188.946 0 0.000%
inner_html 86.013 86.013 0 0.000%
js_callback 112.994 112.994 0 0.000%
keyed_list 201.198 201.198 0 0.000%
mount_point 89.208 89.208 0 0.000%
nested_list 114.492 114.492 0 0.000%
node_refs 96.159 96.159 0 0.000%
password_strength 1583.154 1583.154 0 0.000%
portals 98.239 98.239 0 0.000%
router 313.954 313.954 0 0.000%
simple_ssr 143.631 143.631 0 0.000%
ssr_router 385.079 385.079 0 0.000%
suspense 110.239 110.239 0 0.000%
timer 91.757 91.757 0 0.000%
timer_functional 100.292 100.292 0 0.000%
todomvc 143.697 143.697 0 0.000%
two_apps 89.918 89.918 0 0.000%
web_worker_fib 154.519 154.519 0 0.000%
webgl 88.528 88.528 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 395.086 418.931 405.525 7.487
Hello World 10 732.737 779.951 747.723 15.917
Function Router 10 2279.613 2490.142 2338.208 68.677
Concurrent Task 10 1007.331 1011.085 1008.786 1.228
Many Providers 10 1638.983 1734.277 1673.618 32.908

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 393.789 433.577 407.298 10.115
Hello World 10 732.841 779.083 744.894 13.029
Function Router 10 2275.592 2543.489 2368.159 68.209
Concurrent Task 10 1007.308 1011.048 1009.088 1.108
Many Providers 10 1632.569 1822.611 1725.549 64.487

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this pull request as I do not think the CI failures are related.

@futursolo futursolo merged commit 3e9e253 into yewstack:master Aug 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checked attribute is lost
2 participants