Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the docs of set_event_bubbling #3391

Merged
merged 1 commit into from Sep 23, 2023
Merged

Conversation

schvv31n
Copy link
Contributor

@schvv31n schvv31n commented Sep 1, 2023

Description

Removed a paragraph from the docs of set_event_bubbling which describes a caveat of the framework which is no longer true

Checklist

  • I have reviewed my own code
  • I have added tests

The removed paragraph describes a caveat of the framework which is no longer true
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Visit the preview URL for this PR (updated for commit 9a8bed0):

https://yew-rs-api--pr3391-patch-1-1nqko81d.web.app

(expires Fri, 08 Sep 2023 16:52:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 384.148 384.886 384.258 0.222
Hello World 10 676.769 701.298 696.355 7.114
Function Router 10 2241.498 2282.292 2270.230 12.224
Concurrent Task 10 1006.905 1007.845 1007.477 0.267
Many Providers 10 1600.332 1646.481 1623.636 15.525

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 384.124 386.521 384.492 0.725
Hello World 10 696.057 700.014 697.764 1.114
Function Router 10 2229.801 2244.977 2235.208 4.477
Concurrent Task 10 1006.569 1008.043 1007.289 0.563
Many Providers 10 1581.932 1621.395 1593.483 11.907

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.401 102.401 0 0.000%
boids 175.553 175.553 0 0.000%
communication_child_to_parent 95.218 95.218 0 0.000%
communication_grandchild_with_grandparent 108.881 108.881 0 0.000%
communication_grandparent_to_grandchild 105.540 105.540 0 0.000%
communication_parent_to_child 92.698 92.698 0 0.000%
contexts 110.886 110.886 0 0.000%
counter 89.208 89.208 0 0.000%
counter_functional 89.920 89.920 0 0.000%
dyn_create_destroy_apps 92.289 92.289 0 0.000%
file_upload 103.541 103.541 0 0.000%
function_memory_game 174.375 174.375 0 0.000%
function_router 352.018 352.018 0 0.000%
function_todomvc 163.356 163.356 0 0.000%
futures 227.718 227.718 0 0.000%
game_of_life 112.353 112.353 0 0.000%
immutable 188.946 188.946 0 0.000%
inner_html 86.013 86.013 0 0.000%
js_callback 112.982 112.982 0 0.000%
keyed_list 201.202 201.202 0 0.000%
mount_point 89.206 89.206 0 0.000%
nested_list 114.499 114.499 0 0.000%
node_refs 96.170 96.170 0 0.000%
password_strength 1582.847 1582.847 0 0.000%
portals 98.235 98.235 0 0.000%
router 318.034 318.034 0 0.000%
simple_ssr 143.630 143.630 0 0.000%
ssr_router 389.212 389.212 0 0.000%
suspense 118.655 118.655 0 0.000%
timer 91.808 91.808 0 0.000%
timer_functional 100.316 100.316 0 0.000%
todomvc 143.696 143.696 0 0.000%
two_apps 89.916 89.916 0 0.000%
web_worker_fib 154.528 154.528 0 0.000%
webgl 88.528 88.528 0 0.000%

✅ None of the examples has changed their size significantly.

@hamza1311 hamza1311 added documentation A-yew Area: The main yew crate labels Sep 1, 2023
Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this.

This behaviour should now work correctly for events registered with on* handlers.

Copy link
Member

@cecton cecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe enough to merge 🤷‍♀️ @hamza1311 a second approval for this one?

@futursolo futursolo merged commit 0f2fc59 into yewstack:master Sep 23, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants