Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add neovim configuration doc #3400

Merged
merged 2 commits into from Sep 23, 2023
Merged

Conversation

RazaGR
Copy link
Contributor

@RazaGR RazaGR commented Sep 11, 2023

add neovim configuration documentation to setup with lazy.vim plugin.

Description

Add documentation for usage in neovim.

Checklist

  • I have reviewed my own code

add neovim configuration documentation to setup with lazy.vim plugin.

> Below configuration works with [LazyVim](https://www.lazyvim.org) configuration and lazy.vim plugin, create a file in `lua/plugins/nvim-lspconfig.lua` (or update your `lspconfig`) with:

```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block doesn't look like JSON. Why can't the actual language not be used here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(tbh the one just above (line 137) isn't valid JSON either 😅 not that I care tbh, black&white is my color scheme)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not JSON, its Lua

cecton
cecton previously approved these changes Sep 23, 2023

> Below configuration works with [LazyVim](https://www.lazyvim.org) configuration and lazy.vim plugin, create a file in `lua/plugins/nvim-lspconfig.lua` (or update your `lspconfig`) with:

```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(tbh the one just above (line 137) isn't valid JSON either 😅 not that I care tbh, black&white is my color scheme)

Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran prettier so CI can be green. I'm fine with merging it as is

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 65ccf00):

https://yew-rs--pr3400-razagr-patch-1-lhfbj9s3.web.app

(expires Sat, 30 Sep 2023 13:10:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@hamza1311 hamza1311 merged commit 5bab22d into yewstack:master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants