Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow converting multiple component children to VList #3444

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

ranile
Copy link
Member

@ranile ranile commented Oct 4, 2023

Description

This PR allows converting ChildrenRenderer<VNode> and VChild to VList

Fixes #3443

Checklist

  • I have reviewed my own code
  • I have added tests

@ranile ranile added the A-yew Area: The main yew crate label Oct 4, 2023
@ranile ranile requested a review from futursolo October 4, 2023 17:56
github-actions[bot]
github-actions bot previously approved these changes Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Visit the preview URL for this PR (updated for commit 64041b7):

https://yew-rs-api--pr3444-vlist-props-73x7p29u.web.app

(expires Wed, 11 Oct 2023 18:03:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.919 102.919 0 0.000%
boids 175.669 175.669 0 0.000%
communication_child_to_parent 95.301 95.301 0 0.000%
communication_grandchild_with_grandparent 109.042 109.042 0 0.000%
communication_grandparent_to_grandchild 105.721 105.721 0 0.000%
communication_parent_to_child 92.789 92.789 0 0.000%
contexts 113.470 113.470 0 0.000%
counter 89.197 89.197 0 0.000%
counter_functional 89.930 89.930 0 0.000%
dyn_create_destroy_apps 92.369 92.369 0 0.000%
file_upload 103.514 103.514 0 0.000%
function_memory_game 174.645 174.645 0 0.000%
function_router 353.830 353.830 0 0.000%
function_todomvc 163.451 163.451 0 0.000%
futures 227.444 227.444 0 0.000%
game_of_life 112.217 112.217 0 0.000%
immutable 188.793 188.793 0 0.000%
inner_html 85.981 85.981 0 0.000%
js_callback 113.456 113.456 0 0.000%
keyed_list 201.203 201.203 0 0.000%
mount_point 89.188 89.188 0 0.000%
nested_list 115.764 115.764 0 0.000%
node_refs 96.292 96.292 0 0.000%
password_strength 1721.048 1721.048 0 0.000%
portals 98.361 98.361 0 0.000%
router 319.777 319.777 0 0.000%
simple_ssr 144.232 144.232 0 0.000%
ssr_router 391.617 391.617 0 0.000%
suspense 119.068 119.068 0 0.000%
timer 91.797 91.797 0 0.000%
timer_functional 100.502 100.502 0 0.000%
todomvc 143.688 143.688 0 0.000%
two_apps 89.896 89.896 0 0.000%
web_worker_fib 138.876 138.876 0 0.000%
web_worker_prime 190.421 190.421 0 0.000%
webgl 88.501 88.501 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 319.065 320.791 319.361 0.513
Hello World 10 644.410 646.279 645.145 0.547
Function Router 10 2116.400 2148.727 2130.132 9.610
Concurrent Task 10 1007.378 1008.838 1008.157 0.403
Many Providers 10 1516.977 1532.877 1525.996 6.070

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 319.080 321.686 319.456 0.800
Hello World 10 651.662 654.044 652.093 0.714
Function Router 10 2095.623 2113.405 2105.231 6.340
Concurrent Task 10 1007.335 1008.809 1008.193 0.517
Many Providers 10 1497.844 1528.540 1508.175 9.571

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@futursolo futursolo merged commit 22b3706 into yewstack:master Oct 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struggling with ways to convert someting into Html.
2 participants