Raise MSRV to 1.76 #3693
Open
Raise MSRV to 1.76 #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranile
added
A-yew-router
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit cb63acc): https://yew-rs-api--pr3693-msrv-hnsl5ib9.web.app (expires Fri, 02 Aug 2024 15:36:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
WorldSEnder
requested changes
Jul 26, 2024
| } | ||
|
|
||
| /// Take a single entry, preferring parents over children | ||
| #[rustversion::since(1.66)] | ||
| #[allow(clippy::incompatible_msrv)] |
There was a problem hiding this comment.
I think you can remove this suppression of the false positive of clippy::incompatible_msrv now.
|
I had no major reason other than the fact that this includes lints that use/suppress (cause of unknown lint warning from previous code) and is newer than any before/after rustversion checks that we had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raise MSRV to 1.76
1.76 is (almost*) 6 months old so this change brings Yew's MSRV to the same as Tokio and Hyper.
* It will be 6 months old by first week of August so not a huge deal at the moment
Checklist