Properly handle where clause in derive props macro #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @astraw! For future reference you can run those tests with |
|
bors r+ |
jstarry
approved these changes
Sep 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 22, 2019
640: Properly handle where clause in derive props macro r=jstarry a=astraw This fixes #638. So far, I was not able to the test suite to run, so I wasn't able to write a test for this. Co-authored-by: Andrew Straw <strawman@astraw.com> Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #638.
So far, I was not able to the test suite to run, so I wasn't able to write a test for this.