Reset Select component correctly in Firefox/Edge #987
Merged
+43
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuy
force-pushed
the
reset-select-component
branch
from
7564af3
to
7655260
Compare
kuy
changed the title
kuy
force-pushed
the
reset-select-component
branch
from
7655260
to
c272c2b
Compare
kuy
force-pushed
the
reset-select-component
branch
from
c272c2b
to
b63ad74
Compare
kuy
changed the title
|
@jstarry Thanks for helping me on Gitter. Ready for review. |
jstarry
reviewed
Mar 22, 2020
There was a problem hiding this comment.
I didn't add dedicated example because it's very small. I thought that increasing redundant examples is not good for the project for maintenance cost. Instead of that, I placed "Reset" button in showcase example. This is not MUST feature, but good demonstration.
Great idea! Looks fantastic, thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630
On Firefox/Edge, it's needed to set value using DOM API to reflect a state of dropdown. To hold a reference of
selectelement, I introduced a new fieldselect_ref.I didn't add dedicated example because it's very small. I thought that increasing redundant examples is not good for the project for maintenance cost. Instead of that, I placed "Reset" button in
showcaseexample. This is not MUST feature, but good demonstration.