Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

Have the State type be converted to String for storage in History API #185

Closed
hgzimmerman opened this issue Nov 23, 2019 · 0 comments · Fixed by #201
Closed

Have the State type be converted to String for storage in History API #185

hgzimmerman opened this issue Nov 23, 2019 · 0 comments · Fixed by #201
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others

Comments

@hgzimmerman
Copy link
Member

Description

The state type is usually (), because support for actually storing data in the history api is difficult due to only JS types found in StdWeb being supported.

Instead, always store a string, and use Serde to transform your data into and out of JSON (or possibly bincode - maybe a feature flag for this?)

This shouldn't change the external interface too much, except that now types other than () and String would be able to be possible to store. I think the bound on JsSerializable should be dropped.
@hgzimmerman hgzimmerman added the enhancement New feature or request label Nov 23, 2019
@hgzimmerman hgzimmerman added the high priority Issues with this tag will be worked on before others label Dec 8, 2019
This was referenced Dec 16, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store state as a serialized string yewstack/yew_router
1 participant
@hgzimmerman