EventsSDK: Revise Authorization in AnalyticsConfig #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to fields in AnalyticsConfig that we're optional,
key
andbearer
, where we throw an error if none or both are set. This change updates the interface so it is more clear that only one is required. There is nowauthorizationType
which is either a stringapiKey
orBearer
andauthorization
which is the token itself. We needauthorizationType
so we can append the proper prefix ofKEY
orBearer
to the final authorization property to avoid passing this work onto the user. This also updates necessary test files to reflect this change, and removes logic for ensuring that only one of key or bearer is set.J=FUS-6201
R=abenno, mtian, mkilpatrick
TEST=auto