EventsSDK: Remove Enums #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtian725
reviewed
Jan 25, 2024
I don't think so. I think all existing users would be using the sdk from the script tag, which would point them to the older version still using EnumOrString. |
mtian725
reviewed
Jan 26, 2024
|
Other than the playwright tests failing, LGTM |
mtian725
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned that using enums in TypeScript is bad practice in favor of types. This updates
Environment,Region, andVersionLabelfiles to use types instead of enums. In addition, we delete the EnumOrString type and updatesetupRequestUrland relevant tests.J=FUS-6202
R=abenno, mtian
TEST=auto