Add Support for Pages Analytics #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the main AnalyticsConfig, AnalyticsReporter, etc. to be aliases for SearchAnayticsConfig, SearchAnalytics Reporter, etc. in order to differentiate between the Pages & Search focused parts of the library. Additionally, introduces console debugging support enabled when the `debug` option is set. T=unit & manual Unit tests added for the new PagesAnalyticsReporter. Manually testing done by updating the test-site to add the new provider, fire a page view, and add a button to test click events. Co-authored-by: Ben McGinnis <bmcginnis@yext.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Adds Conversion Tracking to the Analytics Library, including: * New standalone ConversionTrackingReporter * Additions to PagesAnalyticsReporter to allow it to track conversions using the ConversionTrackingReporter as well as properly credit Listings and Pages for conversions that happen later * Adds a CookieManager utility class that can be used by implementers to retrieve the Yext cookieId and set it if need be. TEST=unit & manual * Added unit tests for ConversionTrackingReporter and updated them for PagesAnalyticsReporter. * Additionally updated test site to add relevant buttons for conversion tracking. To test Cookies you will need to serve with a TLS cert on your local.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added for Pages Analytics Events and Conversion Tracking.