Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsSDK: Set up dev/unified-sdk #48

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

ejaffee01
Copy link
Contributor

Delete unused code and reorganize file structure for new version of the Analytics Events SDK.

J=FUS-5866
R=mtian, abenno
TEST=none

Thought to npm run build, but as index.ts is not set up this will fail.

@ejaffee01 ejaffee01 self-assigned this Aug 21, 2023
@ejaffee01 ejaffee01 marked this pull request as ready for review August 21, 2023 18:08
src/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtian725 mtian725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also change the version to "1.0.0" in the package.json

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ejaffee01 ejaffee01 force-pushed the setup-dev/unified-sdk branch 2 times, most recently from 7c33821 to 6dfa83a Compare August 21, 2023 19:26
Ethan Jaffee added 2 commits August 21, 2023 16:26
Delete unused code and reorganize file structure for new version of the
Analytics Events SDK. Update package.json

J=FUS-5866
R=mtian, abenno
TEST=auto

Confirmed build succeeds with npm run build.
Copy link
Contributor

@AjayBenno AjayBenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ejaffee01 ejaffee01 closed this Aug 21, 2023
@ejaffee01 ejaffee01 reopened this Aug 21, 2023
@ejaffee01 ejaffee01 merged commit c4ec3c4 into dev/unified-sdk Aug 21, 2023
18 of 21 checks passed
@ejaffee01 ejaffee01 deleted the setup-dev/unified-sdk branch August 21, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants