-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventsSDK: Set up dev/unified-sdk #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtian725
reviewed
Aug 21, 2023
mtian725
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also change the version to "1.0.0" in the package.json
8ea391e
to
ab34b2e
Compare
AjayBenno
reviewed
Aug 21, 2023
7c33821
to
6dfa83a
Compare
AjayBenno
reviewed
Aug 21, 2023
Delete unused code and reorganize file structure for new version of the Analytics Events SDK. Update package.json J=FUS-5866 R=mtian, abenno TEST=auto Confirmed build succeeds with npm run build.
5a23650
to
9f29931
Compare
b3f0189
to
450a9b6
Compare
AjayBenno
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete unused code and reorganize file structure for new version of the Analytics Events SDK.
J=FUS-5866
R=mtian, abenno
TEST=none
Thought to npm run build, but as index.ts is not set up this will fail.