Skip to content

Commit

Permalink
v1.29.4 (#1107)
Browse files Browse the repository at this point in the history
### Bug Fixes
- Fixes an analytics issue where certain analytics events were reported without a `searcher`, causing the requests to fail (#1106)
  • Loading branch information
nmanu1 committed Oct 25, 2022
2 parents b01f0be + aaad24e commit 223c682
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 11 deletions.
7 changes: 3 additions & 4 deletions directanswercards/card_component.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ BaseDirectAnswerCard["{{componentName}}"] = class extends ANSWERS.Component {
this.validateDataForRender(cardData);
return super.setState({
...cardData,
searcher: data.searcher,
feedbackEnabled: ANSWERS.getAnalyticsOptIn(),
feedbackSubmitted: data.feedbackSubmitted,
isArray: Array.isArray(this.answer.value),
Expand Down Expand Up @@ -97,7 +96,7 @@ BaseDirectAnswerCard["{{componentName}}"] = class extends ANSWERS.Component {
.addOptions({
directAnswer: true,
verticalKey: this.verticalConfigId,
searcher: this.getState('searcher'),
searcher: this._config.data.searcher,
entityId: this.associatedEntityId
});

Expand All @@ -120,7 +119,7 @@ BaseDirectAnswerCard["{{componentName}}"] = class extends ANSWERS.Component {
*/
addDefaultEventOptions(eventOptions = {}) {
return Object.assign({}, {
searcher: this.getState('searcher'),
searcher: this._config.data.searcher,
verticalConfigId: this.verticalConfigId,
entityId: this.associatedEntityId,
...eventOptions
Expand All @@ -144,7 +143,7 @@ BaseDirectAnswerCard["{{componentName}}"] = class extends ANSWERS.Component {
verticalKey: this.verticalConfigId,
directAnswer: true,
fieldName: this.answer.fieldApiName,
searcher: this.getState('searcher'),
searcher: this._config.data.searcher,
entityId: this.associatedEntityId,
url: event.target.href
};
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.29.3",
"version": "1.29.4",
"description": "A starter Search theme for hitchhikers",
"keywords": [
"jambo",
"jambo",
"templates",
"handlebars",
"site",
Expand Down
4 changes: 2 additions & 2 deletions static/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion static/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.29.3",
"version": "1.29.4",
"description": "Toolchain for use with the HH Theme",
"main": "Gruntfile.js",
"scripts": {
Expand Down

0 comments on commit 223c682

Please sign in to comment.