Skip to content

Commit

Permalink
add static placeholders for the searchbar and nav components (#797)
Browse files Browse the repository at this point in the history
This component adds static html placeholders for the searchbar
and nav components, which will be displayed prior to the SDK
loading and components being added to the page.
Also adds the `Answers-navigation` css class to navigation markup
templates that were missing it and the `js-answersSearchBar` id to
all searchbar markup templates that were missing it.

J=SLAP-1336
TEST=manual

see that on each of the 5 page templates, the searchbar and nav
placeholders will display for a brief second before the page finishes
loading
  • Loading branch information
oshi97 committed May 28, 2021
1 parent 44c39d1 commit c03b0e4
Show file tree
Hide file tree
Showing 20 changed files with 200 additions and 15 deletions.
20 changes: 19 additions & 1 deletion templates/universal-standard/markup/navigation.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
<div class="Answers-nav js-answersNavigation"></div>
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation">
<nav class="yxt-Nav-container js-yxt-navContainer ">
<ul class="yxt-Nav-expanded" aria-label="Search Page Navigation">
<li>
{{!--
This is a placeholder tab so that the placeholder nav bar
takes the expected amount of space on the page
--}}
<a class="js-yxt-navItem yxt-Nav-item is-active"
data-middleclick="active"
data-eventtype="ALL_TAB_NAVIGATION"
style="visibility: hidden;"
>
placeholder
</a>
</li>
</ul>
</nav>
</div>
15 changes: 14 additions & 1 deletion templates/universal-standard/markup/searchbar.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
<div class="Answers-search js-answersSearch"></div>
<div class="Answers-search js-answersSearch" id="js-answersSearchBar">
<div class="yxt-SearchBar">
<div class="yxt-SearchBar-container">
<form class="yxt-SearchBar-form">
<input
class="js-yext-query yxt-SearchBar-input"
id="yxt-SearchBar-input--SearchBar"
type="text"
name="query"
>
</form>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion templates/universal-standard/script/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ verticalPages: [
}{{#unless @last}},{{/unless}}
{{/if}}
{{/each}}
]
],
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.Navigation }}}));

{{!--
Expand Down
3 changes: 3 additions & 0 deletions templates/universal-standard/script/searchbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,7 @@ const shouldAddOverlayConfig = window.isOverlay && document.querySelector('.js-A
ANSWERS.addComponent("SearchBar", Object.assign({}, {
container: ".js-answersSearch",
...(shouldAddOverlayConfig ? overlayConfig : {}),
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.SearchBar }}}));
20 changes: 19 additions & 1 deletion templates/vertical-full-page-map/markup/navigation.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation"></div>
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation">
<nav class="yxt-Nav-container js-yxt-navContainer ">
<ul class="yxt-Nav-expanded" aria-label="Search Page Navigation">
<li>
{{!--
This is a placeholder tab so that the placeholder nav bar
takes the expected amount of space on the page
--}}
<a class="js-yxt-navItem yxt-Nav-item is-active"
data-middleclick="active"
data-eventtype="ALL_TAB_NAVIGATION"
style="visibility: hidden;"
>
placeholder
</a>
</li>
</ul>
</nav>
</div>
15 changes: 14 additions & 1 deletion templates/vertical-full-page-map/markup/searchbar.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
<div class="Answers-search js-answersSearch" id="js-answersSearchBar"></div>
<div class="Answers-search js-answersSearch" id="js-answersSearchBar">
<div class="yxt-SearchBar">
<div class="yxt-SearchBar-container">
<form class="yxt-SearchBar-form">
<input
class="js-yext-query yxt-SearchBar-input"
id="yxt-SearchBar-input--SearchBar"
type="text"
name="query"
>
</form>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion templates/vertical-full-page-map/script/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ verticalPages: [
}{{#unless @last}},{{/unless}}
{{/if}}
{{/each}}
]
],
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.Navigation }}}));

{{!--
Expand Down
3 changes: 3 additions & 0 deletions templates/vertical-full-page-map/script/searchbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ ANSWERS.addComponent("SearchBar", Object.assign({}, {
verticalKey: "{{{verticalKey}}}",
{{/if}}
...(shouldAddOverlayConfig ? overlayConfig : {}),
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.SearchBar }}}));
20 changes: 19 additions & 1 deletion templates/vertical-grid/markup/navigation.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
<div class="Answers-nav js-answersNavigation"></div>
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation">
<nav class="yxt-Nav-container js-yxt-navContainer ">
<ul class="yxt-Nav-expanded" aria-label="Search Page Navigation">
<li>
{{!--
This is a placeholder tab so that the placeholder nav bar
takes the expected amount of space on the page
--}}
<a class="js-yxt-navItem yxt-Nav-item is-active"
data-middleclick="active"
data-eventtype="ALL_TAB_NAVIGATION"
style="visibility: hidden;"
>
placeholder
</a>
</li>
</ul>
</nav>
</div>
15 changes: 14 additions & 1 deletion templates/vertical-grid/markup/searchbar.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
<div class="Answers-search js-answersSearch"></div>
<div class="Answers-search js-answersSearch" id="js-answersSearchBar">
<div class="yxt-SearchBar">
<div class="yxt-SearchBar-container">
<form class="yxt-SearchBar-form">
<input
class="js-yext-query yxt-SearchBar-input"
id="yxt-SearchBar-input--SearchBar"
type="text"
name="query"
>
</form>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion templates/vertical-grid/script/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ verticalPages: [
}{{#unless @last}},{{/unless}}
{{/if}}
{{/each}}
]
],
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.Navigation }}}));

{{!--
Expand Down
3 changes: 3 additions & 0 deletions templates/vertical-grid/script/searchbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ ANSWERS.addComponent("SearchBar", Object.assign({}, {
verticalKey: "{{{verticalKey}}}",
{{/if}}
...(shouldAddOverlayConfig ? overlayConfig : {}),
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.SearchBar }}}));
20 changes: 19 additions & 1 deletion templates/vertical-map/markup/navigation.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation"></div>
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation">
<nav class="yxt-Nav-container js-yxt-navContainer ">
<ul class="yxt-Nav-expanded" aria-label="Search Page Navigation">
<li>
{{!--
This is a placeholder tab so that the placeholder nav bar
takes the expected amount of space on the page
--}}
<a class="js-yxt-navItem yxt-Nav-item is-active"
data-middleclick="active"
data-eventtype="ALL_TAB_NAVIGATION"
style="visibility: hidden;"
>
placeholder
</a>
</li>
</ul>
</nav>
</div>
15 changes: 14 additions & 1 deletion templates/vertical-map/markup/searchbar.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
<div class="Answers-search js-answersSearch" id="js-answersSearchBar"></div>
<div class="Answers-search js-answersSearch" id="js-answersSearchBar">
<div class="yxt-SearchBar">
<div class="yxt-SearchBar-container">
<form class="yxt-SearchBar-form">
<input
class="js-yext-query yxt-SearchBar-input"
id="yxt-SearchBar-input--SearchBar"
type="text"
name="query"
>
</form>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion templates/vertical-map/script/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ verticalPages: [
}{{#unless @last}},{{/unless}}
{{/if}}
{{/each}}
]
],
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.Navigation }}}));

{{!--
Expand Down
3 changes: 3 additions & 0 deletions templates/vertical-map/script/searchbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ ANSWERS.addComponent("SearchBar", Object.assign({}, {
verticalKey: "{{{verticalKey}}}",
{{/if}}
...(shouldAddOverlayConfig ? overlayConfig : {}),
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.SearchBar }}}));
20 changes: 19 additions & 1 deletion templates/vertical-standard/markup/navigation.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
<div class="Answers-nav js-answersNavigation"></div>
<div class="Answers-nav Answers-navigation js-answersNavigation" id="js-answersNavigation">
<nav class="yxt-Nav-container js-yxt-navContainer ">
<ul class="yxt-Nav-expanded" aria-label="Search Page Navigation">
<li>
{{!--
This is a placeholder tab so that the placeholder nav bar
takes the expected amount of space on the page
--}}
<a class="js-yxt-navItem yxt-Nav-item is-active"
data-middleclick="active"
data-eventtype="ALL_TAB_NAVIGATION"
style="visibility: hidden;"
>
placeholder
</a>
</li>
</ul>
</nav>
</div>
15 changes: 14 additions & 1 deletion templates/vertical-standard/markup/searchbar.hbs
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
<div class="Answers-search js-answersSearch" id="js-answersSearchBar"></div>
<div class="Answers-search js-answersSearch" id="js-answersSearchBar">
<div class="yxt-SearchBar">
<div class="yxt-SearchBar-container">
<form class="yxt-SearchBar-form">
<input
class="js-yext-query yxt-SearchBar-input"
id="yxt-SearchBar-input--SearchBar"
type="text"
name="query"
>
</form>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion templates/vertical-standard/script/navigation.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ verticalPages: [
}{{#unless @last}},{{/unless}}
{{/if}}
{{/each}}
]
],
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.Navigation }}}));

{{!--
Expand Down
3 changes: 3 additions & 0 deletions templates/vertical-standard/script/searchbar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ ANSWERS.addComponent("SearchBar", Object.assign({}, {
verticalKey: "{{{verticalKey}}}",
{{/if}}
...(shouldAddOverlayConfig ? overlayConfig : {}),
onCreate: function() {
this._container.textContent = '';
}
}, {{{ json componentSettings.SearchBar }}}));

0 comments on commit c03b0e4

Please sign in to comment.