Skip to content

Commit

Permalink
Display buttons if feedbackEnabled (#1003)
Browse files Browse the repository at this point in the history
Display thumbs up/down feedback buttons on product-prominentvideo cards whenever feedback is enabled, even if there are no details or CTAs.

J=SLAP-1701
TEST=manual

Check that test-site has thumbs up/down buttons appearing accordingly on product-prominentvideo cards
  • Loading branch information
nmanu1 committed Nov 15, 2021
1 parent 8744bc9 commit dd3db33
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cards/multilang-product-prominentvideo/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
{{/inline}}

{{#*inline 'content'}}
{{#if (any card.details (all card.CTA1 card.CTA1.url card.CTA1.label) (all card.CTA2 card.CTA2.url card.CTA2.label))}}
{{#if (any card.details (all card.CTA1 card.CTA1.url card.CTA1.label) (all card.CTA2 card.CTA2.url card.CTA2.label) card.feedbackEnabled)}}
<div class="HitchhikerProductProminentVideo-contentWrapper">
{{> details }}
<div class="HitchhikerCard-actions">
Expand Down
2 changes: 1 addition & 1 deletion cards/product-prominentvideo/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
{{/inline}}

{{#*inline 'content'}}
{{#if (any card.details (all card.CTA1 card.CTA1.url card.CTA1.label) (all card.CTA2 card.CTA2.url card.CTA2.label))}}
{{#if (any card.details (all card.CTA1 card.CTA1.url card.CTA1.label) (all card.CTA2 card.CTA2.url card.CTA2.label) card.feedbackEnabled)}}
<div class="HitchhikerProductProminentVideo-contentWrapper">
{{> details }}
<div class="HitchhikerCard-actions">
Expand Down

0 comments on commit dd3db33

Please sign in to comment.