Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 12 deprecation warnings #1113

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 6, 2022

Update actions/checkout and actions/setup-node GH actions to remove Node 12 deprecation warnings.

J=SLAP-2468
TEST=manual

See that the acceptance and translation test workflows no longer have warnings on the Test commit.

@coveralls
Copy link

coveralls commented Dec 6, 2022

Coverage Status

Coverage remained the same at 8.75% when pulling f3364d4 on dev/remove-node-12 into 0fe1372 on release/v1.30.

@nmanu1 nmanu1 merged commit f8620fc into release/v1.30 Dec 6, 2022
@nmanu1 nmanu1 deleted the dev/remove-node-12 branch December 6, 2022 20:26
@tmeyer2115 tmeyer2115 mentioned this pull request Dec 15, 2022
tmeyer2115 added a commit that referenced this pull request Dec 15, 2022
### Changes
- If `initializeManually` is `true`, initialization will happen automatically in Live Preview. This is to improve local development experience. (#1088)
- Support for IE11 was officially dropped. We no longer guarantee that subsequent Theme versions will be IE11 compatible. (#1112)
- Assorted updates were made to our GH Actions. (#1113, #1111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants