dateRange formatter: Use dateFormatOptions for same-day end times #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an end date is on the same day, the dateRange formatter will not show the month, day, and year of the end date, only the time. However, it was passing in the default format options with month, day, and year removed instead of using the format options passed in through the dateFormatOptions parameter. This update makes it so that dateFormatOptions are respected for end times with only the options for month, day, and year removed. J=PC-201542 TEST=manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an end date is on the same day, the dateRange formatter will not show the month, day, and year of the end date, only the time.
However, it was passing in the default format options with month, day, and year removed instead of using the format options passed in through the dateFormatOptions parameter.
This update makes it so that dateFormatOptions are respected for end times with only the options for month, day, and year removed.
J=PC-201542
TEST=manual