Support EU Cloud Region #1134
Merged
Support EU Cloud Region #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cloud region config option to the global_config to allow either 'us' (default), or 'eu' to be set as the cloud region. The cloud region determines where the search assets and ytag are sourced from. J=BACK-2277 TEST=manual Using the test site, set the cloudRegion to eu and confirmed the assets are loaded from the eu cdn. Currently there is a cors error, but I will retest them once Aether fixes it.
benmcginnis
approved these changes
May 4, 2023
| @@ -24,8 +24,12 @@ | |||
| <link rel="dns-prefetch" href="//dynl.mktgcdn.com"> | |||
| <link rel="dns-prefetch" href="//dynm.mktgcdn.com"> | |||
There was a problem hiding this comment.
do we know if these domains will be different @EmilyZhang777 ?
There was a problem hiding this comment.
I'm not sure. Based on this conversation, seems like eu is going to another bucket?
benmcginnis
approved these changes
May 9, 2023
EmilyZhang777
approved these changes
May 9, 2023
| @@ -24,8 +24,12 @@ | |||
| <link rel="dns-prefetch" href="//dynl.mktgcdn.com"> | |||
| <link rel="dns-prefetch" href="//dynm.mktgcdn.com"> | |||
There was a problem hiding this comment.
I'm not sure. Based on this conversation, seems like eu is going to another bucket?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cloud region config option to the global_config to allow either 'us' (default), or 'eu' to be set as the cloud region.
The cloud region determines where the search assets and ytag are sourced from.
J=BACK-2277
TEST=manual, auto
Using the test site, set the cloudRegion to "eu" and confirmed the assets are loaded from the EU CDN and executed searches against the EU search endpoints