Fix iframe Answers Map/List toggle button on Mobile Error #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iframe needs height in order for map and toggle button to be initialized and to fill js-answersMap
benmcginnis
reviewed
Sep 26, 2023
static/js/iframe-common.js
Outdated
| @@ -70,6 +70,8 @@ export function generateIFrame(domain, answersExperienceFrame) { | |||
| iframe.frameBorder = 0; | |||
|
|
|||
| // For dynamic iFrame sizing | |||
| iframe.style.height = '100%'; | |||
| iframe.style.minHeight = '100%'; | |||
There was a problem hiding this comment.
I'm a little uncertain about this solution. There are a lot of potential problems with setting 100% height.
Can we take a look at this with a test across a few different browsers?
There was a problem hiding this comment.
I think we should first look at upgrading iframe-resizer which is responsible for resizing the iframe to fill the view height. It's possible there is a bug there: https://www.npmjs.com/package/iframe-resizer
cea2aj
reviewed
Sep 26, 2023
| el.style.height = `${el.scrollHeight}px` | ||
| } | ||
| } | ||
| //NOTE: set min-height for js-answersMap instead to prevent keyboard from shifting the page |
There was a problem hiding this comment.
If we don't need this code we can delete it instead of commenting it out
cea2aj
previously approved these changes
Sep 27, 2023
cea2aj
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iframe needs height in order for map and toggle button to be initialized and to fill js-answersMap