Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master (v1.33.3) into develop #1162

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Merge master (v1.33.3) into develop

This PR fixes a couple bugs in the styling of the search overlay where the height and width styling did not have the correct units and were therefore invalid values and not being applied.

In cases where the overlay loaded quickly and the default height and width were applied to the overlay button before the label text was added, the button would remain that smaller default size and hide the label text because the computed height and width were missing the `px` units. In the cases where the label text was added before the overlay button finished loading and having its styling applied, the label text would be correctly visible even without this change, which is why it seemed mostly functional so far.

I also noticed another place where `px` units were being added to a `100vh` height value, which would make it invalid. I wasn't able to find a scenario in which this was causing issues for the account from the techops, but other implementations could be affected depending on their setup.

J=TECHOPS-10727
TEST=manual

Make these changes in the account from the techops and see the overlay styling is fixed and the label text is correctly displayed in the instances where it previously was hidden.
### Fixes
- Fixed bugs in search overlay styling that caused the label text to sometimes be hidden (#1160)
@nmanu1 nmanu1 merged commit 819809a into develop Dec 12, 2023
17 checks passed
@nmanu1 nmanu1 deleted the dev/merge-v1.33.3-f2d3f2b-into-develop branch December 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant