Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Theme dependencies according to Dependabot's suggestions. #780

Merged
merged 1 commit into from
May 13, 2021

Conversation

tmeyer2115
Copy link
Collaborator

Dependabot suggested we update the following dependencies:

  • hosted-git-info from 2.8.8 to 2.8.9.
  • postcss from 8.1.4 to 8.2.10.
  • lodash from 4.17.20 to 4.17.21.
  • grunt from 1.1.0 to 1.3.0.

TEST=manual

Built a local Jambo site and ensured the served site looked as expected. Also
verified that the Grunt watch task still worked.

Dependabot suggested we update the following dependencies:
- hosted-git-info from 2.8.8 to 2.8.9.
- postcss from 8.1.4 to 8.2.10.
- lodash from 4.17.20 to 4.17.21.
- grunt from 1.1.0 to 1.3.0.

TEST=manual

Built a local Jambo site and ensured the served site looked as expected. Also
verified that the Grunt watch task still worked.
@tmeyer2115 tmeyer2115 requested a review from oshi97 May 13, 2021 16:26
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tmeyer2115 tmeyer2115 merged commit 3dc1f51 into feature/update-deps May 13, 2021
@tmeyer2115 tmeyer2115 deleted the dev/dependabot-suggestions branch May 13, 2021 16:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 4.724% when pulling fe09227 on dev/dependabot-suggestions into 94c60fe on feature/update-deps.

tmeyer2115 added a commit that referenced this pull request May 13, 2021
… (#781)

Dependabot suggested we update the following dependencies:
- hosted-git-info from 2.8.8 to 2.8.9.
- postcss from 8.1.4 to 8.2.10.
- lodash from 4.17.20 to 4.17.21.
- grunt from 1.1.0 to 1.3.0.

TEST=manual

Built a local Jambo site and ensured the served site looked as expected. Also
verified that the Grunt watch task still worked.
@cea2aj cea2aj mentioned this pull request Jun 23, 2021
cea2aj added a commit that referenced this pull request Jun 23, 2021
## Version 1.22.0
### Changes
- Code coverage reports are now generated automatically for the Theme. (#759)
- A number of dependencies were updated in accordance with Dependabot's suggestions. (#780)
- The build time in `Development` mode was reduced significantly. (#782, #829) Build times in 
`Production` mode were also decreased. (#783, #825)
- Two new cards supporting videos were added: `product-prominentvideo` and `multilang-product-prominentvideo`. These cards
work with either YouTube or Vimeo content. (#794)
- The process for formatting hours was made more efficient, resulting in faster renders for cards with hours. (#784)
- Any SDK branch can now be specified in the `global_config.sdkVersion` attribute. (#791)
- Unused CSS was removed from the Theme. (#793, #798)
- To reduce flashing related to the SDK Component lifecycle, placeholder skeletons were added for the `SearchBar` and
`Navigation` components. (#797)
- Additional acceptance tests were added for the `VerticalFullPageMap` and Percy snapshots are now generated for all
cards. (#830, #820)
- Multi-language tests were added for the Theme. (#826)
- The `documentsearch-standard` card now supports rich text featured snippets. (#838)
- A new concept, `RuntimeConfig` was added. This allows configuration, computed at run-time, to be injected into the
Theme and SDK. This new concept enables JWT integrations as well. (#843)
### Bug Fixes
- A number of changes were made to make the Theme's visual regression tests more reliable. (#764, #765, #766, #778)
- Corrected how the CTA URLs for the `menuitem-standard` and `multilang-menuitem-standard` cards are computed. (#787)
- The Google Streetview person icon is now visible when using the `VerticalFullPageMap` layout. (#801)
- The size of the cluster and result pins are now configurable. (#807)
- A double encoding error for `verticalUrl` was fixed. (#836)
- The `Opens At` open status message is now properly translated in all languages. (#834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants