v1.22.1 #864
Merged
v1.22.1 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that for all result cards, when an RTF link is clicked, the correct `AnalyticsEvent` is fired. This code is largely taken from the SDK's `CardComponent` class. The only difference is in how some of the event options are computed. J=SLAP-1403 TEST=manual Tested the following: - Event was properly fired for a link click on vertical. - Event was properly fired for a link click on universal. - Clicking elsewhere on an RTF value (not a link) did not cause an event to fire.
This PR ensures that all Direct Answer cards in the Theme support RTF link click analytics. The code was taken largely from the SDK. The main difference is the source of some of the event options. J=SLAP-1405 TEST=manual Built a local test site with the new base `card_component`. Saw the correct `AnalyticsEvent`s getting fired when I clicked on a RTF DA's links. Verified that clicking plain text in the RTF value did not cause an event to be fired.
cea2aj
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes