remove gcp related changes and nit3

yext · May 11, 2024 · 856f988 · 856f988
1 parent a51ac1c
commit 856f988
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml
@@ -39,7 +39,6 @@ jobs:
     secrets:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
 
 concurrency:
   group: ci-build-and-deploy-${{ github.ref }}-1

diff --git a/.github/workflows/build_and_deploy_i18n.yml b/.github/workflows/build_and_deploy_i18n.yml
@@ -45,7 +45,6 @@ jobs:
     secrets:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
 
   call_deploy_canary:
     if: github.ref_name == 'develop'
@@ -61,7 +60,6 @@ jobs:
     secrets:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
 
   call_deploy_canary_sha:
     if: github.ref_name == 'develop'
@@ -78,7 +76,6 @@ jobs:
     secrets:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
 
 concurrency:
   group: ci-build-and-deploy-i18n-${{ github.ref }}-1

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -19,8 +19,6 @@ on:
         required: true
       AWS_SECRET_ACCESS_KEY:
         required: true
-      GCP_SA_KEY:
-        required: true
 
 jobs:
   deploy-aws:
@@ -43,4 +41,4 @@ jobs:
           aws s3 cp ./dist/ s3://assets.sitescdn.net/${{ inputs.bucket }}/${{ inputs.directory }} \
           --acl public-read \
           --recursive \
-          --cache-control ${{ inputs.cache-control }}
+          --cache-control ${{ inputs.cache-control }}