Skip to content

Commit

Permalink
Fix google map inValidValueError (#1548)
Browse files Browse the repository at this point in the history
- allow config to pass a pin label that is an empty string instead of defaulting to SDK built-in label got GoogleMapProvider (only use when label is not specified at all in config)

J=SLAP-655
TEST=manual

launched theme's test site, and see that theme's pin label config (empty string) is used instead of default marker label
  • Loading branch information
yen-tt authored and cea2aj committed Apr 8, 2022
1 parent d3a7635 commit 9846a9b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/components/map/providers/googlemapprovider.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class GoogleMapMarkerConfig {
}

let label;
if (pinConfigObj.label) {
if (pinConfigObj.label || pinConfigObj.label === '') {
label = pinConfigObj.label;
} else {
label = marker.label.toString();
Expand Down

0 comments on commit 9846a9b

Please sign in to comment.