remove unused verticalKey config from Facets + FilterBox (#1724)

verticalKey is not used internally by these components anywhere. J=SLAP-2041 TEST=manual facets + filterbox still work
yext · Apr 19, 2022 · b8d8f00 · b8d8f00
1 parent cfe5753
commit b8d8f00
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -1346,8 +1346,6 @@ ANSWERS.addComponent('FilterBox', {
       ]
     }
   ],
-  // Required, the vertical key for the search, default null
-  verticalKey: 'verticalKey',
   // Optional, title to display above the filter
   title: 'Filters',
   // Optional, show number of results for each filter
@@ -1395,8 +1393,6 @@ The Facets component displays filters relevant to the current search, configured
 ANSWERS.addComponent('Facets', {
   // Required, the selector for the container element where the component will be injected
   container: '.facets-container',
-  // Required
-  verticalKey: '<VERTICAL_KEY>',
   // Optional, title to display above the facets
   title: 'Filters',
   // Optional, show number of results for each facet

diff --git a/conf/i18n/translations/messages.pot b/conf/i18n/translations/messages.pot
@@ -474,12 +474,12 @@ msgctxt "Title of section"
 msgid "Ask a Question"
 msgstr ""
 
-#: src/ui/components/filters/facetscomponent.js:306
+#: src/ui/components/filters/facetscomponent.js:299
 msgctxt "True or False"
 msgid "False"
 msgstr ""
 
-#: src/ui/components/filters/facetscomponent.js:303
+#: src/ui/components/filters/facetscomponent.js:296
 msgctxt "True or False"
 msgid "True"
 msgstr ""

diff --git a/src/ui/components/filters/facetscomponent.js b/src/ui/components/filters/facetscomponent.js
@@ -186,13 +186,6 @@ export default class FacetsComponent extends Component {
 
     this.config = new FacetsConfig(config);
 
-    /**
-     * The vertical key for the search
-     * @type {string}
-     * @private
-     */
-    this._verticalKey = config.verticalKey;
-
     /**
      * The selector of the apply button
      * @type {string}
@@ -355,7 +348,6 @@ export default class FacetsComponent extends Component {
         parentContainer: this._container,
         name: `${this.name}.filterbox`,
         container: '.js-yxt-Facets',
-        verticalKey: this._verticalKey,
         resetFilter: this.config.resetFacet,
         resetFilters: this.config.resetFacets,
         resetFilterLabel: this.config.resetFacetLabel,

diff --git a/src/ui/components/filters/filterboxcomponent.js b/src/ui/components/filters/filterboxcomponent.js
@@ -154,13 +154,6 @@ export default class FilterBoxComponent extends Component {
         'FilterBox');
     }
 
-    /**
-     * The vertical key for the search
-     * @type {string}
-     * @private
-     */
-    this._verticalKey = config.verticalKey || null;
-
     /**
      * The components created for each filter config
      * @type {Component[]}